Skip to content

Commit c8598e9

Browse files
committed
Little refactor
1 parent 9a66c5d commit c8598e9

File tree

1 file changed

+20
-10
lines changed

1 file changed

+20
-10
lines changed

llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

+20-10
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,17 @@ SPIRVEmitNonSemanticDI::SPIRVEmitNonSemanticDI() : MachineFunctionPass(ID) {
6262
initializeSPIRVEmitNonSemanticDIPass(*PassRegistry::getPassRegistry());
6363
}
6464

65+
enum BaseTypeAttributeEncoding {
66+
Unspecified = 0,
67+
Address = 1,
68+
Boolean = 2,
69+
Float = 3,
70+
Signed = 4,
71+
SignedChar = 5,
72+
Unsigned = 6,
73+
UnsignedChar = 7
74+
};
75+
6576
bool SPIRVEmitNonSemanticDI::emitGlobalDI(MachineFunction &MF) {
6677
// If this MachineFunction doesn't have any BB repeat procedure
6778
// for the next
@@ -119,9 +130,8 @@ bool SPIRVEmitNonSemanticDI::emitGlobalDI(MachineFunction &MF) {
119130
if (auto *DVR = dyn_cast<DbgVariableRecord>(&DR)) {
120131
DILocalVariable *LocalVariable = DVR->getVariable();
121132
if (auto *BasicType =
122-
dyn_cast<DIBasicType>(LocalVariable->getType())) {
133+
dyn_cast<DIBasicType>(LocalVariable->getType()))
123134
BasicTypes.insert(BasicType);
124-
}
125135
}
126136
}
127137
}
@@ -212,28 +222,28 @@ bool SPIRVEmitNonSemanticDI::emitGlobalDI(MachineFunction &MF) {
212222
const Register ConstIntBitwidthReg = GR->buildConstantInt(
213223
BasicType->getSizeInBits(), MIRBuilder, I32Ty, false);
214224

215-
uint64_t AttributeEncoding = 0;
225+
uint64_t AttributeEncoding = BaseTypeAttributeEncoding::Unspecified;
216226
switch (BasicType->getEncoding()) {
217227
case dwarf::DW_ATE_signed:
218-
AttributeEncoding = 4;
228+
AttributeEncoding = BaseTypeAttributeEncoding::Signed;
219229
break;
220230
case dwarf::DW_ATE_unsigned:
221-
AttributeEncoding = 6;
231+
AttributeEncoding = BaseTypeAttributeEncoding::Unsigned;
222232
break;
223233
case dwarf::DW_ATE_unsigned_char:
224-
AttributeEncoding = 7;
234+
AttributeEncoding = BaseTypeAttributeEncoding::UnsignedChar;
225235
break;
226236
case dwarf::DW_ATE_signed_char:
227-
AttributeEncoding = 5;
237+
AttributeEncoding = BaseTypeAttributeEncoding::SignedChar;
228238
break;
229239
case dwarf::DW_ATE_float:
230-
AttributeEncoding = 3;
240+
AttributeEncoding = BaseTypeAttributeEncoding::Float;
231241
break;
232242
case dwarf::DW_ATE_boolean:
233-
AttributeEncoding = 2;
243+
AttributeEncoding = BaseTypeAttributeEncoding::Boolean;
234244
break;
235245
case dwarf::DW_ATE_address:
236-
AttributeEncoding = 1;
246+
AttributeEncoding = BaseTypeAttributeEncoding::Address;
237247
}
238248

239249
const Register AttributeEncodingReg =

0 commit comments

Comments
 (0)