Skip to content

Commit c8fad4f

Browse files
authored
[flang][OpenMP][NFC] Reduce OMPMarkDeclareTarget boilerplate (#93797)
The pass constructor can be generated automatically by tablegen. This pass does not need adapting to work with non-function top level operations because it operates specifically on call operations inside of an OpenMP declare target function.
1 parent 60a890d commit c8fad4f

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

flang/include/flang/Optimizer/Transforms/Passes.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ namespace fir {
5252
#define GEN_PASS_DECL_LOOPVERSIONING
5353
#define GEN_PASS_DECL_ADDALIASTAGS
5454
#define GEN_PASS_DECL_OMPMAPINFOFINALIZATIONPASS
55+
#define GEN_PASS_DECL_OMPMARKDECLARETARGETPASS
5556
#include "flang/Optimizer/Transforms/Passes.h.inc"
5657

5758
std::unique_ptr<mlir::Pass> createAffineDemotionPass();
@@ -72,8 +73,6 @@ std::unique_ptr<mlir::Pass>
7273
createAlgebraicSimplificationPass(const mlir::GreedyRewriteConfig &config);
7374

7475
std::unique_ptr<mlir::Pass> createOMPFunctionFilteringPass();
75-
std::unique_ptr<mlir::OperationPass<mlir::ModuleOp>>
76-
createOMPMarkDeclareTargetPass();
7776

7877
std::unique_ptr<mlir::Pass> createVScaleAttrPass();
7978
std::unique_ptr<mlir::Pass>

flang/include/flang/Optimizer/Transforms/Passes.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ def OMPMapInfoFinalizationPass
337337
def OMPMarkDeclareTargetPass
338338
: Pass<"omp-mark-declare-target", "mlir::ModuleOp"> {
339339
let summary = "Marks all functions called by an OpenMP declare target function as declare target";
340-
let constructor = "::fir::createOMPMarkDeclareTargetPass()";
341340
let dependentDialects = ["mlir::omp::OpenMPDialect"];
342341
}
343342

flang/lib/Optimizer/Transforms/OMPMarkDeclareTarget.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,3 @@ class OMPMarkDeclareTargetPass
8888
};
8989

9090
} // namespace
91-
92-
namespace fir {
93-
std::unique_ptr<mlir::OperationPass<mlir::ModuleOp>>
94-
createOMPMarkDeclareTargetPass() {
95-
return std::make_unique<OMPMarkDeclareTargetPass>();
96-
}
97-
} // namespace fir

0 commit comments

Comments
 (0)