[SimplifyLibCalls] Use helper methods to query attributes (NFC)

nikic · nikic · commit df8264c46ab1 · 2022-10-11T11:41:28.000+02:00
diff --git a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
@@ -2515,8 +2515,7 @@ static bool isTrigLibCall(CallInst *CI) {
   // We can only hope to do anything useful if we can ignore things like errno
   // and floating-point exceptions.
   // We already checked the prototype.
-  return CI->hasFnAttr(Attribute::NoUnwind) &&
-         CI->hasFnAttr(Attribute::ReadNone);
+  return CI->doesNotThrow() && CI->doesNotAccessMemory();
 }
 
 static bool insertSinCosCall(IRBuilderBase &B, Function *OrigCallee, Value *Arg,

Original file line number	Diff line number	Diff line change
`@@ -2515,8 +2515,7 @@ static bool isTrigLibCall(CallInst *CI) {`
`2515`	`2515`	`// We can only hope to do anything useful if we can ignore things like errno`
`2516`	`2516`	`// and floating-point exceptions.`
`2517`	`2517`	`// We already checked the prototype.`
`2518`		`- return CI->hasFnAttr(Attribute::NoUnwind) &&`
`2519`		`- CI->hasFnAttr(Attribute::ReadNone);`
	`2518`	`+ return CI->doesNotThrow() && CI->doesNotAccessMemory();`
`2520`	`2519`	`}`
`2521`	`2520`
`2522`	`2521`	`static bool insertSinCosCall(IRBuilderBase &B, Function OrigCallee, Value Arg,`