Skip to content

Commit fd80048

Browse files
authored
[GlobalISel][AArch64] Handles bitreverse to prevent falling back (#138150)
Handles bitreverse for vector types which were previously falling back onto Selection DAG. Includes 8-bit element vectors greater than 128 bits and less than 64 bits: <32 x i8>, <4 x i8>, and odd vector types: <9 x i8>.
1 parent f2f4eac commit fd80048

File tree

3 files changed

+47
-0
lines changed

3 files changed

+47
-0
lines changed

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -6136,6 +6136,7 @@ LegalizerHelper::moreElementsVector(MachineInstr &MI, unsigned TypeIdx,
61366136
case TargetOpcode::G_INTRINSIC_ROUND:
61376137
case TargetOpcode::G_INTRINSIC_ROUNDEVEN:
61386138
case TargetOpcode::G_INTRINSIC_TRUNC:
6139+
case TargetOpcode::G_BITREVERSE:
61396140
case TargetOpcode::G_BSWAP:
61406141
case TargetOpcode::G_FCANONICALIZE:
61416142
case TargetOpcode::G_SEXT_INREG:

llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,8 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
366366
.legalFor({s32, s64, v8s8, v16s8})
367367
.widenScalarToNextPow2(0, /*Min = */ 32)
368368
.clampScalar(0, s32, s64)
369+
.clampNumElements(0, v8s8, v16s8)
370+
.moreElementsToNextPow2(0)
369371
.lower();
370372

371373
getActionDefinitionsBuilder(G_BSWAP)

llvm/test/CodeGen/AArch64/bitreverse.ll

+44
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,50 @@ define <16 x i8> @g_vec_16x8(<16 x i8> %a) {
136136
ret <16 x i8> %b
137137
}
138138

139+
declare <32 x i8> @llvm.bitreverse.v32i8(<32 x i8>) readnone
140+
141+
define <32 x i8> @g_vec_32x8(<32 x i8> %a) {
142+
; CHECK-LABEL: g_vec_32x8:
143+
; CHECK: // %bb.0:
144+
; CHECK-NEXT: rbit v0.16b, v0.16b
145+
; CHECK-NEXT: rbit v1.16b, v1.16b
146+
; CHECK-NEXT: ret
147+
%b = call <32 x i8> @llvm.bitreverse.v32i8(<32 x i8> %a)
148+
ret <32 x i8> %b
149+
}
150+
151+
declare <4 x i8> @llvm.bitreverse.v4i8(<4 x i8>) readnone
152+
153+
define <4 x i8> @g_vec_4x8(<4 x i8> %a) {
154+
; SDAG-LABEL: g_vec_4x8:
155+
; SDAG: // %bb.0:
156+
; SDAG-NEXT: rev16 v0.8b, v0.8b
157+
; SDAG-NEXT: rbit v0.8b, v0.8b
158+
; SDAG-NEXT: ushr v0.4h, v0.4h, #8
159+
; SDAG-NEXT: ret
160+
;
161+
; GISEL-LABEL: g_vec_4x8:
162+
; GISEL: // %bb.0:
163+
; GISEL-NEXT: uzp1 v0.8b, v0.8b, v0.8b
164+
; GISEL-NEXT: rbit v0.8b, v0.8b
165+
; GISEL-NEXT: ushll v0.8h, v0.8b, #0
166+
; GISEL-NEXT: // kill: def $d0 killed $d0 killed $q0
167+
; GISEL-NEXT: ret
168+
%b = call <4 x i8> @llvm.bitreverse.v4i8(<4 x i8> %a)
169+
ret <4 x i8> %b
170+
}
171+
172+
declare <9 x i8> @llvm.bitreverse.v9i8(<9 x i8>) readnone
173+
174+
define <9 x i8> @g_vec_9x8(<9 x i8> %a) {
175+
; CHECK-LABEL: g_vec_9x8:
176+
; CHECK: // %bb.0:
177+
; CHECK-NEXT: rbit v0.16b, v0.16b
178+
; CHECK-NEXT: ret
179+
%b = call <9 x i8> @llvm.bitreverse.v9i8(<9 x i8> %a)
180+
ret <9 x i8> %b
181+
}
182+
139183
declare <4 x i16> @llvm.bitreverse.v4i16(<4 x i16>) readnone
140184

141185
define <4 x i16> @g_vec_4x16(<4 x i16> %a) {

0 commit comments

Comments
 (0)