Backport #113446 to 19.x

[anutosh491]

Hi,

I am interested in a PR #113446 that I would like to have in the release (if possible in 19.1.4)
The PR works towards allowing clang-repl to run in the browser. It is a small but essential change.

[anutosh491]

cc @aheejin

[aheejin]

You can request for a backport merge with this process: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches

[anutosh491]

/cherry-pick d61f58f

[anutosh491]

You can request for a backport merge with this process

Thanks. I hope should be enough (I thought it is only a maintainer that could probably pick commit for a release)

[aheejin]

I am not a release maintainer either 😀

[llvmbot]

/cherry-pick d61f58f

Error: Command failed due to missing milestone.

[aheejin]

/cherry-pick d61f58f

Re-posting this after adding the milestone

[llvmbot]

Failed to cherry-pick: d61f58f

https://github.com/llvm/llvm-project/actions/runs/11793878279

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

[llvmbot]

Failed to cherry-pick: d61f58f

https://github.com/llvm/llvm-project/actions/runs/11793890929

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

[anutosh491]

Hi @tru

Could you maybe tell us if we're doing something wrong here. Just did what the docs suggested.

[aheejin]

It says the cherry-pick failed because of conflicts. I think you should locally do a cherry-pick of the commit on top of release/19.x branch, resolve conflicts, test if it works well, and create a PR against the release/19.x branch as the doc says.

[tru]

What @aheejin said. There are conflicts so you need to manually resolve those.

[anutosh491]

Well I don't think I have a conflicts issue. I am seeing this (https://github.com/llvm/llvm-project/actions/runs/11793878279)

git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git cherry-pick -x d61f58f66839652ec4c1101521c2a7297cffacff
  stderr: 'fatal: bad object d61f58f66839652ec4c1101521c2a7297cffacff'
  

Not sure if directly creating a PR against the release/19.x works.

[anutosh491]

Here's one with the same changes as d61f58f
#115846

Not sure I could do a cherry pick as @aheejin suggested.

[aheejin]

/cherry-pick 075581f

#113446's commit is 075581f. I think we should cherry-pick this one

[llvmbot]

/pull-request #115848