MachineSanitizerBinaryMetadata modifies original IR as a MachineFunction pass

[arsenm]

llvm-project/llvm/lib/CodeGen/SanitizerBinaryMetadata.cpp

Line 82 in c480874

F.setMetadata(

This violates the rules of codegen, where we assume the underlying IR never changes.

For the purposes of what this pass is doing, it should not be a machine pass. It is only checking the size and alignment of stack passed arguments. The ABI is exactly computable from an IR signature, and does not require going through codegen to get this information.