You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#121323 changed the way the absolute path is computed.
This led to HeaderFilterRegex not picked up from the .clang-tidy file sitting at the current working directory. This has partially been fixed by #133582, but nevertheless this should be fixed here as well.
Before the PR:
Getting options for file ''
AbsolutePath: /path/to/root/
After the PR:
Getting options for file ''
AbsolutePath: /path/to/root
I.e. there is a missing trailing slash. This makes the addRawFileOptions no longer work, because it does this:
https://github.com//pull/121323 changed the way the absolute path is computed.
This led to `HeaderFilterRegex` not picked up from the `.clang-tidy` file sitting at the current working directory. This has partially been fixed by https://github.com//pull/133582, but nevertheless this should be fixed here as well.
Before the PR:
Getting options for file ''
AbsolutePath: /path/to/root/
After the PR:
Getting options for file ''
AbsolutePath: /path/to/root
I.e. there is a missing trailing slash. This makes the addRawFileOptions no longer work, because it does this:
#121323 changed the way the absolute path is computed.
This led to
HeaderFilterRegex
not picked up from the.clang-tidy
file sitting at the current working directory. This has partially been fixed by #133582, but nevertheless this should be fixed here as well.Before the PR:
After the PR:
I.e. there is a missing trailing slash. This makes the
addRawFileOptions
no longer work, because it does this:Since the
AbsolutePath
no longer has a slash, instead of picking/path/to/root
asRootPath
, it picks/path/to
, and there is no.clang-tidy
file there.The text was updated successfully, but these errors were encountered: