You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Fortran] Disabling error tests and tests not yet working with HLFIR (#47)
Patch required before enabling HLFIR by default:
llvm/llvm-project#72090
Three batches of tests must be disabled.
1. test using non constant length character elemental fuctions
2. test using pointer assignments inside FORALL
3. "error" test that previously "wrongly" pass (did not throw errors)
For the first two batches, lowering without HFLIR handled a few cases
, but did not fully handle the features correctly. With HLFIR, it was
decided to make all cases TODO until the feature are handled correctly.
They are not very common, hence I think the "feature regression" is
acceptable for now compared to what HLFIR brings.
For, the last batch, the test suite is not set to run error checking
tests (verifying a runtime error that is expected from the runtime
given an invalid Fortran input), so the test suits considered a "pass"
tests that where run with no error while invalid.
HLFIR with -O1 uses the runtime in cases where the previous lowering did
things inline, the usage of the runtime allow catching these invalid
program as expected, but since the test suit is not set up yet to deal
with negative runtime tests, they must be disabled.
maxlocval1 is also removed until more investigation is done (failing at -O3 on arm with HLFIR).
0 commit comments