Skip to content

Commit 9b940d3

Browse files
authored
log which image is being pulled (#58)
1 parent 2058453 commit 9b940d3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ You can configure the Docker behaviour using the `@LocalstackDockerProperties` a
7878
| `portElasticSearch` | Port number for the elasticsearch service | String | `4571` |
7979
| `hostNameResolver` | Used for determining the host name of the machine running the docker containers so that the containers can be addressed. | IHostNameResolver | `localhost` |
8080
| `environmentVariableProvider` | Used for injecting environment variables into the container. | IEnvironmentVariableProvider | Empty Map |
81-
| `bindMountProvider | Used bind mounting files and directories into the container, useful to run init scripts before using the container. | IBindMountProvider | Empty Map |
82-
| initializationToken | Give a regex that will be searched in the logstream of the container, start is complete only when the token is found. Use with bindMountProvider to execute init scripts. | String | Empty String |
81+
| `bindMountProvider` | Used bind mounting files and directories into the container, useful to run init scripts before using the container. | IBindMountProvider | Empty Map |
82+
| `initializationToken` | Give a regex that will be searched in the logstream of the container, start is complete only when the token is found. Use with bindMountProvider to execute init scripts. | String | Empty String |
8383
| `useSingleDockerContainer` | Whether a singleton container should be used by all test classes. | boolean | `false` |
8484

8585
For more details, please refer to the README of the main LocalStack repo: https://github.com/localstack/localstack

src/main/java/cloud/localstack/docker/Container.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public static Container createLocalstackContainer(
7575
+ ":" + LOCALSTACK_PORT_ELASTICSEARCH;
7676

7777
if(pullNewImage || !imageExists) {
78-
LOG.info("Pulling latest image...");
78+
LOG.info(String.format("Pulling image %s", fullImageName));
7979
new PullCommand(imageNameOrDefault, imageTag).execute();
8080
}
8181

@@ -84,15 +84,15 @@ public static Container createLocalstackContainer(
8484
.withExposedPorts(fullPortElasticSearch, randomizePorts)
8585
.withEnvironmentVariable(LOCALSTACK_EXTERNAL_HOSTNAME, externalHostName)
8686
.withEnvironmentVariable(ENV_DEBUG, ENV_DEBUG_DEFAULT)
87-
.withEnvironmentVariable(ENV_USE_SSL, Localstack.INSTANCE.useSSL() ? "1" : "0")
87+
.withEnvironmentVariable(ENV_USE_SSL, Localstack.useSSL() ? "1" : "0")
8888
.withEnvironmentVariables(environmentVariables)
8989
.withBindMountedVolumes(bindMounts);
9090

9191
if(!StringUtils.isEmpty(platform))
9292
runCommand = runCommand.withPlatform(platform);
9393

9494
for (Integer port : portMappings.keySet()) {
95-
runCommand = runCommand.withExposedPorts("" + port, false);
95+
runCommand = runCommand.withExposedPorts(String.valueOf(port), false);
9696
}
9797
String containerId = runCommand.execute();
9898
LOG.info("Started container: " + containerId);

0 commit comments

Comments
 (0)