SNOW-241508 stabilizing codecov (snowflakedb#564)

Author: sfc-gh-mkeller

Diff for: src/snowflake/connector/cursor.py

@@ -72,6 +72,7 @@
 
 ASYNC_NO_DATA_MAX_RETRY = 24
 ASYNC_RETRY_PATTERN = [1, 1, 2, 3, 4, 8, 10]
+INCIDENT_BLACKLIST = (KeyError, ValueError, TypeError)
 
 
 def exit_handler(*_):  # pragma: no cover
@@ -516,10 +517,9 @@ def execute(self,
                 # TODO we could probably rework this to not make dicts like this: {'1': 'value', '2': '13'}
                 processed_params = self._connection._process_params_qmarks(params, self)
         # Skip reporting Key, Value and Type errors
-        except (KeyError, ValueError, TypeError):
-            raise
-        except Exception:
-            self.connection.incident.report_incident()
+        except Exception as exc:  # pragma: no cover
+            if not isinstance(exc, INCIDENT_BLACKLIST):
+                self.connection.incident.report_incident()
             raise
 
         m = DESC_TABLE_RE.match(query)
@@ -954,7 +954,7 @@ def wait_until_ready():
                 status = self.connection.get_query_status(sfqid)
                 if not self.connection.is_still_running(status):
                     break
-                if status == QueryStatus.NO_DATA:
+                if status == QueryStatus.NO_DATA:  # pragma: no cover
                     no_data_counter += 1
                     if no_data_counter > ASYNC_NO_DATA_MAX_RETRY:
                         raise DatabaseError("Cannot retrieve data on the status of this query. No information returned "

Diff for: test/integ/test_async.py

@@ -18,6 +18,18 @@
     QueryStatus = None
 
 
+def test_simple_async(conn_cnx):
+    """Simple test to that shows the most simple usage of fire and forget.
+
+    This test also makes sure that wait_until_ready function's sleeping is tested.
+    """
+    with conn_cnx() as con:
+        with con.cursor() as cur:
+            cur.execute_async('select count(*) from table(generator(timeLimit => 5))')
+            cur.get_results_from_sfqid(cur.sfqid)
+            assert len(cur.fetchall()) == 1
+
+
 def test_async_exec(conn_cnx):
     """Tests whether simple async query execution works.
 

Diff for: test/integ/test_connection.py

@@ -924,3 +924,14 @@ def test_process_param_dict_error(conn_cnx):
                             side_effect=Exception('test')):
                 conn._process_params({'asd': 'something'})
             assert pe.errno == ER_FAILED_PROCESSING_PYFORMAT
+
+
+@pytest.mark.skipolddriver
+def test_process_param_error(conn_cnx):
+    """Tests whether exceptions in __process_params_dict are handled correctly."""
+    with conn_cnx() as conn:
+        with pytest.raises(ProgrammingError, match="Failed processing pyformat-parameters; test") as pe:
+            with mock.patch('snowflake.connector.converter.SnowflakeConverter.to_snowflake',
+                            side_effect=Exception('test')):
+                conn._process_params(mock.Mock())
+            assert pe.errno == ER_FAILED_PROCESSING_PYFORMAT

Diff for: test/unit/test_converter.py

@@ -6,7 +6,11 @@
 
 from logging import getLogger
 
+import pytest
+
+from snowflake.connector import ProgrammingError
 from snowflake.connector.connection import DefaultConverterClass
+from snowflake.connector.converter import SnowflakeConverter
 from snowflake.connector.converter_snowsql import SnowflakeConverterSnowSQL
 
 logger = getLogger(__name__)
@@ -66,3 +70,15 @@ def test_more_timestamps():
     assert m('-2208943503.8765432') == '1900-01-01 12:34:56.123456800'
     assert m('-2208943503.0000000') == '1900-01-01 12:34:57.000000000'
     assert m('-2208943503.0120000') == '1900-01-01 12:34:56.988000000'
+
+
+def test_converter_to_snowflake_error():
+    converter = SnowflakeConverter()
+    with pytest.raises(ProgrammingError, match=r'Binding data in type \(bogus\) is not supported'):
+        converter._bogus_to_snowflake('Bogus')
+
+
+def test_converter_to_snowflake_bindings_error():
+    converter = SnowflakeConverter()
+    with pytest.raises(ProgrammingError, match=r'Binding data in type \(somethingsomething\) is not supported'):
+        converter._somethingsomething_to_snowflake_bindings('Bogus')

Diff for: tox.ini

@@ -5,6 +5,7 @@ show_missing = True
 branch = true
 parallel = true
 omit = */snowflake/connector/tool/*
+       src/snowflake/connector/incident.py
 [coverage:paths]
 source = src/snowflake/connector
          */.tox/*/lib/python*/site-packages/snowflake/connector
@@ -45,7 +46,9 @@ setenv =
     unit: SNOWFLAKE_TEST_TYPE = unit
     integ: SNOWFLAKE_TEST_TYPE = integ
     # Add common parts into pytest command
-    SNOWFLAKE_PYTEST_CMD = pytest {env:SNOWFLAKE_PYTEST_OPTS:} --cov snowflake.connector --junitxml {env:JUNIT_REPORT_DIR:{toxworkdir}}/junit.{envname}-{env:cloud_provider:dev}.xml
+    SNOWFLAKE_PYTEST_COV_LOCATION = {env:JUNIT_REPORT_DIR:{toxworkdir}}/junit.{envname}-{env:cloud_provider:dev}.xml
+    SNOWFLAKE_PYTEST_COV_CMD = --cov snowflake.connector --junitxml {env:SNOWFLAKE_PYTEST_COV_LOCATION} --cov-report=
+    SNOWFLAKE_PYTEST_CMD = pytest {env:SNOWFLAKE_PYTEST_OPTS:} {env:SNOWFLAKE_PYTEST_COV_CMD}
 passenv =
     AWS_ACCESS_KEY_ID
     AWS_SECRET_ACCESS_KEY