Skip to content

Commit d1625e7

Browse files
authored
Revert "Issue graphql-python#1111: make ForeignKeys resolve symmetrically (v2)"
1 parent 0b23dd7 commit d1625e7

File tree

4 files changed

+10
-448
lines changed

4 files changed

+10
-448
lines changed

graphene_django/converter.py

+1-18
Original file line numberDiff line numberDiff line change
@@ -254,24 +254,7 @@ def dynamic_type():
254254
if not _type:
255255
return
256256

257-
class CustomField(Field):
258-
def get_resolver(self, parent_resolver):
259-
"""
260-
Implements a custom resolver which go through the `get_node` method to insure that
261-
it goes through the `get_queryset` method of the DjangoObjectType.
262-
"""
263-
resolver = super(CustomField, self).get_resolver(parent_resolver)
264-
265-
def custom_resolver(root, info, **args):
266-
fk_obj = resolver(root, info, **args)
267-
if fk_obj is None:
268-
return None
269-
else:
270-
return _type.get_node(info, fk_obj.pk)
271-
272-
return custom_resolver
273-
274-
return CustomField(_type, description=field.help_text, required=not field.null)
257+
return Field(_type, description=field.help_text, required=not field.null)
275258

276259
return Dynamic(dynamic_type)
277260

graphene_django/tests/models.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ class Person(models.Model):
1313
class Pet(models.Model):
1414
name = models.CharField(max_length=30)
1515
age = models.PositiveIntegerField()
16-
owner = models.ForeignKey(
17-
"Person", null=True, blank=True, on_delete=models.CASCADE, related_name="pets"
18-
)
1916

2017

2118
class FilmDetails(models.Model):
@@ -94,8 +91,8 @@ class Meta:
9491

9592
class Article(models.Model):
9693
headline = models.CharField(max_length=100)
97-
pub_date = models.DateField(auto_now_add=True)
98-
pub_date_time = models.DateTimeField(auto_now_add=True)
94+
pub_date = models.DateField()
95+
pub_date_time = models.DateTimeField()
9996
reporter = models.ForeignKey(
10097
Reporter, on_delete=models.CASCADE, related_name="articles"
10198
)

0 commit comments

Comments
 (0)