[test] Covered all the databases used in handleEvent

Author: andsel

build.gradle

@@ -40,7 +40,7 @@ plugins {
 group "org.logstash.filters"
 version "${new File("VERSION").text.trim()}"
 
-String junitVersion = '5.9.2'
+String junitVersion = '5.11.2' // at least 5.11 is needed to use @FieldSource with @ParameterizedTest
 String maxmindGeoip2Version = '2.17.0'
 String maxmindDbVersion = '2.1.0'
 String log4jVersion = '2.17.1'

src/test/java/org/logstash/filters/geoip/GeoIPFilterTest.java

@@ -2,6 +2,7 @@
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.FieldSource;
 import org.junit.jupiter.params.provider.ValueSource;
 import org.logstash.Event;
 
@@ -25,6 +26,12 @@ class GeoIPFilterTest {
     private static final String SOURCE_FIELD = "ip";
     private static final String TARGET_FIELD = "data";
 
+    // used as parameters of givenDatabaseWithCustomizedFieldWhenItsAccessedTheCustomizedIPShouldntThrowAnyErrorAndReportTheLookupAsFailure
+    @SuppressWarnings("unused")
+    static Path[] databases = {MaxMindDatabases.GEOIP2_COUNTRY, MaxMindDatabases.GEOIP2_ANONYMOUS_IP,
+            MaxMindDatabases.GEOIP2_ENTERPRISE, MaxMindDatabases.GEOIP2_DOMAIN, MaxMindDatabases.GEOIP2_ISP,
+            MaxMindDatabases.GEOLITE2_ASN};
+
     @ParameterizedTest
     @ValueSource(booleans = {true, false})
     void handleEventWithGeoIp2CityDatabaseShouldProperlyCreateEvent(boolean ecsEnabled) {
@@ -266,9 +273,10 @@ void handleEventWithNoCustomFieldsShouldUseDatabasesDefaultFields() {
         }
     }
 
-    @Test
-    void givenDatabaseWithCustomizedFieldWhenItsAccessedTheCustomizedIPShouldntThrowAnyErrorAndReportTheLookupAsFailure() {
-        try (final GeoIPFilter filter = createFilter(MaxMindDatabases.GEOIP2_COUNTRY, true, Collections.emptyList())) {
+    @ParameterizedTest
+    @FieldSource("databases")
+    void givenDatabaseWithCustomizedFieldWhenItsAccessedTheCustomizedIPShouldntThrowAnyErrorAndReportTheLookupAsFailure(Path geoDatabase) {
+        try (final GeoIPFilter filter = createFilter(geoDatabase, true, Collections.emptyList())) {
             final RubyEvent rubyEvent = createRubyEvent("216.160.83.60");
             assertFalse(filter.handleEvent(rubyEvent), "Lookup of data point with invalid custom fields should report as failed");
         }