Skip to content

Commit 22c868d

Browse files
mashhursyaauie
andauthored
Apply suggestions from code review
Set to bugfix version, accept detailed overview about the change. Co-authored-by: Ry Biesemeyer <[email protected]>
1 parent ad889cd commit 22c868d

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

Diff for: CHANGELOG.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
## 11.10.0
2-
- Feature: reject unsupported events before sending bulk request to Elasticsearch. [#1080](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1080)
1+
## 11.9.1
2+
- Fixes a possible infinite-retry-loop that could occur when this plugin is configured with an `action` whose value contains a [sprintf-style placeholder][] that fails to be resolved for an individual event. Events in this state will be routed to the pipeline's [dead letter queue][DLQ] if it is available, or will be logged-and-dropped so that the remaining events in the batch can be processed [#1080](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1080)
3+
4+
[sprintf-style placeholder]: https://www.elastic.co/guide/en/logstash/current/event-dependent-configuration.html#sprintf
5+
[DLQ]: https://www.elastic.co/guide/en/logstash/current/dead-letter-queues.html
36

47
## 11.9.0
58
- Feature: force unresolved dynamic index names to be sent into DLQ. This feature could be explicitly disabled using `dlq_on_failed_indexname_interpolation` setting [#1084](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1084)

Diff for: docs/index.asciidoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ The Elasticsearch action to perform. Valid actions are:
395395
document if not already present. See the `doc_as_upsert` option. NOTE: This does not work and is not supported
396396
in Elasticsearch 1.x. Please upgrade to ES 2.x or greater to use this feature with Logstash!
397397
- A sprintf style string to change the action based on the content of the event. The value `%{[foo]}`
398-
would use the foo field for the action. If resolved action is not in [`index`, `delete`, `create`, `update`], the event will be ignored and send to DLQ, if enabled.
398+
would use the foo field for the action. If resolved action is not in [`index`, `delete`, `create`, `update`], the event will not be sent to {es}, and instead either will be sent to the pipeline's <<dead-letter-queues,dead letter queue (DLQ)>> if it is enabled, or will be logged and dropped.
399399

400400
For more details on actions, check out the {ref}/docs-bulk.html[Elasticsearch bulk API documentation].
401401

Diff for: logstash-output-elasticsearch.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Gem::Specification.new do |s|
22
s.name = 'logstash-output-elasticsearch'
3-
s.version = '11.10.0'
3+
s.version = '11.9.1'
44
s.licenses = ['apache-2.0']
55
s.summary = "Stores logs in Elasticsearch"
66
s.description = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

0 commit comments

Comments
 (0)