Moved test about target_ingest_pipeline and ingest_document into the proper context

Author: andsel

Diff for: spec/unit/outputs/elasticsearch_spec.rb

@@ -299,20 +299,20 @@
         context "when the event contains an integration metadata index" do
           let(:event_fields) { super().merge({"@metadata" => {"_ingest_document" => {"index" => "meta-document-index"}}}) }
 
-          it "plugin's configuration metadata index is used" do
+          it "event's metadata index is used" do
             expect(subject.send(:event_action_tuple, event)[1]).to include(:_index => "meta-document-index")
           end
 
           context "when datastream settings are NOT configured" do
-            it "plugin's configuration metadata index is used" do
+            it "event's metadata index is used" do
               expect(subject.send(:event_action_tuple, event)[1]).to include(:_index => "meta-document-index")
             end
           end
 
           context "when datastream settings are configured" do
             let(:event_fields) { super().merge({"data_stream" => {"type" => "logs", "dataset" => "generic", "namespace" => "default"}}) }
 
-            it "plugin's configuration metadata index is used" do
+            it "event's metadata index is used" do
               expect(subject.send(:event_action_tuple, event)[1]).to include(:_index => "meta-document-index")
             end
           end
@@ -365,7 +365,7 @@
         context "when the event contains an integration metadata document_id" do
           let(:event) { LogStash::Event.new({"@metadata" => {"_ingest_document" => {"id" => "meta-document-id"}}}) }
 
-          it "plugin's configuration metadata document_id is used" do
+          it "event's metadata document_id is used" do
             expect(subject.send(:event_action_tuple, event)[1]).to include(:_id => "meta-document-id")
           end
         end
@@ -399,11 +399,20 @@
         let(:options) { super().merge("pipeline" => nil)}
 
         context "when the event contains an integration metadata pipeline" do
-          let(:event) { LogStash::Event.new({"@metadata" => {"_ingest_document" => {"pipeline" => "integration-pipeline"}}}) }
+          let(:metadata) { {"_ingest_document" => {"pipeline" => "integration-pipeline"}} }
+          let(:event) { LogStash::Event.new({"@metadata" => metadata}) }
 
           it "event's metadata pipeline is used" do
             expect(subject.send(:event_action_tuple, event)[1]).to include(:pipeline => "integration-pipeline")
           end
+
+          context "when also target_ingest_pipeline id defined" do
+            let(:metadata) { super().merge({"target_ingest_pipeline" => "meta-ingest-pipeline"}) }
+
+            it "then event's pipeline from _ingest_document is used" do
+              expect(subject.send(:event_action_tuple, event)[1]).to include(:pipeline => "integration-pipeline")
+            end
+          end
         end
 
         context "when the event DOESN'T contains an integration metadata pipeline" do
@@ -894,24 +903,6 @@
         expect(subject.send(:event_action_tuple, event)[1]).to include(:pipeline => "my-ingest-pipeline")
       end
 
-      context "when event contains also _ingest_document pipeline name" do
-        let(:event) { LogStash::Event.new({"pipeline" => "my-ingest-pipeline",
-                                           "@metadata" => {"target_ingest_pipeline" => "meta-ingest-pipeline",
-                                                           "_ingest_document" => {"pipeline" => "integration-pipeline"}}}) }
-
-        it "precedence is given to the integration" do
-          expect(subject.send(:event_action_tuple, event)[1]).to include(:pipeline => "my-ingest-pipeline")
-        end
-
-        context "when settings doesn't configure a pipeline and integration provides one in the event" do
-          let(:options) { { } }
-
-          it "the one provided by user takes precedence on all the others" do
-            expect(subject.send(:event_action_tuple, event)[1]).to include(:pipeline => "integration-pipeline")
-          end
-        end
-      end
-
       context "when the plugin's `pipeline` is constant" do
         let(:options) { super().merge("pipeline" => "my-constant-pipeline") }
          it "uses plugin's pipeline value" do