Skip to content

Commit d61b2be

Browse files
author
CircleCI
committed
fix CR
1 parent efee7a0 commit d61b2be

File tree

2 files changed

+5
-3
lines changed
  • instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions

2 files changed

+5
-3
lines changed

Diff for: CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.13.0-0.34b0...HEAD)
9+
- `opentelemetry-instrumentation-botocore` add support for `messaging.*` in the sqs extension.
10+
([#1350](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1350))
911

1012
### Deprecated
1113

Diff for: instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/sqs.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
_SUPPORTED_OPERATIONS = ["SendMessage", "SendMessageBatch", "ReceiveMessage"]
2525

26-
logger = logging.getLogger(__name__)
26+
_logger = logging.getLogger(__name__)
2727

2828

2929
class _SqsExtension(_AwsSdkExtension):
@@ -39,7 +39,7 @@ def extract_attributes(self, attributes: _AttributeMapT):
3939
SpanAttributes.MESSAGING_DESTINATION
4040
] = queue_url.split("/")[-1]
4141
except IndexError:
42-
logger.error(
42+
_logger.error(
4343
"Could not extract messaging destination from '%s'",
4444
queue_url,
4545
)
@@ -66,4 +66,4 @@ def on_success(self, span: Span, result: _BotoResultT):
6666
result["Messages"][0]["MessageId"],
6767
)
6868
except (IndexError, KeyError):
69-
logger.error("Could not extract the messaging message if")
69+
_logger.error("Could not extract the messaging message ID")

0 commit comments

Comments
 (0)