Skip to content

Commit 6c5e85e

Browse files
committed
Upgrade commons-lang3 to fix SystemUtils.isJavaVersionAtLeast crashing on Java 10 & 11
org.apache.maven.plugin.PluginExecutionException: Execution default of goal net.orfjackal.retrolambda:retrolambda-maven-plugin:2.5.6-SNAPSHOT:process-main failed. at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:143) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 19 more Caused by: java.lang.NullPointerException at org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast(SystemUtils.java:1626) at net.orfjackal.retrolambda.maven.ProcessClassesMojo.validateFork(ProcessClassesMojo.java:146) at net.orfjackal.retrolambda.maven.ProcessClassesMojo.execute(ProcessClassesMojo.java:119) at net.orfjackal.retrolambda.maven.ProcessMainClassesMojo.execute(ProcessMainClassesMojo.java:17) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) ... 20 more
1 parent df5e002 commit 6c5e85e

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

.idea/libraries/Maven__org_apache_commons_commons_lang3_3_5.xml renamed to .idea/libraries/Maven__org_apache_commons_commons_lang3_3_8_1.xml

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

+4
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,10 @@ yourself or pay someone to do it, if you think it's worth the effort. ;)
241241
Version History
242242
---------------
243243

244+
### Upcoming
245+
246+
- Fix a `NullPointerException` crash in the Maven plugin on Java 10 & 11
247+
244248
### Retrolambda 2.5.5 (2018-08-14)
245249

246250
- Fix an `ArrayIndexOutOfBoundsException` crash in ASM due to incorrect bytecode

retrolambda-maven-plugin/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<dependency>
6262
<groupId>org.apache.commons</groupId>
6363
<artifactId>commons-lang3</artifactId>
64-
<version>3.5</version>
64+
<version>3.8.1</version>
6565
</dependency>
6666

6767
</dependencies>

retrolambda-maven-plugin/retrolambda-maven-plugin.iml

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<orderEntry type="library" name="Maven: org.sonatype.plexus:plexus-sec-dispatcher:1.3" level="project" />
4242
<orderEntry type="library" name="Maven: org.sonatype.plexus:plexus-cipher:1.4" level="project" />
4343
<orderEntry type="library" name="Maven: com.google.guava:guava:18.0" level="project" />
44-
<orderEntry type="library" name="Maven: org.apache.commons:commons-lang3:3.5" level="project" />
44+
<orderEntry type="library" name="Maven: org.apache.commons:commons-lang3:3.8.1" level="project" />
4545
<orderEntry type="library" scope="TEST" name="Maven: junit:junit:4.12" level="project" />
4646
<orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-library:1.3" level="project" />
4747
<orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-core:1.3" level="project" />

scripts/build.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ JAVA_HOME="$JAVA6_HOME" mvn clean verify \
4040
-P java6
4141

4242
# Java 9 has stricter bytecode validation than Java 8,
43-
# so make sure that Retrolambda can run under Java 9 (without forking)
43+
# so make sure that Retrolambda can run under new Java versions (without forking)
4444

4545
JAVA_HOME="$JAVA9_HOME" mvn clean verify \
4646
--errors
47+
JAVA_HOME="$JAVA10_HOME" mvn clean verify \
48+
--errors
49+
JAVA_HOME="$JAVA11_HOME" mvn clean verify \
50+
--errors

0 commit comments

Comments
 (0)