Skip to content

Support Electron v25 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willemdjong opened this issue Jul 19, 2023 · 6 comments
Closed

Support Electron v25 #52

willemdjong opened this issue Jul 19, 2023 · 6 comments
Labels
solved ✔ This issue has been solved / answered

Comments

@willemdjong
Copy link

Hello,

I'm reaching out to request support for Electron v25. I'm experiencing a crash with the following error message: "Error: Could not detect abi for version 25.2.0 and runtime electron. Updating 'node-abi' might help solve this issue if it is a new release of Electron."

Thank you in advance for your assistance.

Best regards,

@m4heshd
Copy link
Owner

m4heshd commented Jul 19, 2023

Hi,

I've already added the support in 3c76237 but never did a release for just that. It's gonna need a new beta release for the package.

Subscribe to release notifications. I'll try to do a beta as soon as I get some free time.

@m4heshd m4heshd added the work-in-progress ⚙️ This feature/issue is currently being worked on label Jul 19, 2023
@m4heshd
Copy link
Owner

m4heshd commented Jul 19, 2023

UPDATE:

It seems like I can do a stable release 8.5.0 since @mceachen also did because of all the nagging at WiseLibs/better-sqlite3#1013. 😆

@willemdjong
Copy link
Author

Thanks @m4heshd much appreciated!

@m4heshd
Copy link
Owner

m4heshd commented Jul 19, 2023

Just released v8.5.0. Prebuilt binaries will be ready in a couple of hours. Closing the issue.

@willemdjong
Copy link
Author

willemdjong commented Aug 2, 2023

@m4heshd Referring back to your previous fix, it appears that there might be a missing prebuilt binary package for Windows. Here's the relevant log:

  • electron-builder  version=24.6.3 os=22.2.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=release/build/builder-effective-config.yaml
  • rebuilding native dependencies  [email protected] platform=win32 arch=arm64
  • install prebuilt binary  name=better-sqlite3-multiple-ciphers version=8.5.0 platform=win32 arch=arm64 napi=
  ⨯ cannot build native dependency  reason=prebuild-install failed with error and build from sources not possible because platform or arch not compatible
                                    cause=exit status 1
                                    errorOut=prebuild-install info begin Prebuild-install version 7.1.1
    prebuild-install warn install prebuilt binaries enforced with --force!
    prebuild-install warn install prebuilt binaries may be out of date!
    prebuild-install info looking for local prebuild @ prebuilds/better-sqlite3-multiple-ciphers-v8.5.0-electron-v116-win32-arm64.tar.gz
    prebuild-install info looking for cached prebuild @ /Users/user/.npm/_prebuilds/095f9e-better-sqlite3-multiple-ciphers-v8.5.0-electron-v116-win32-arm64.tar.gz
    prebuild-install http request GET https://github.com/m4heshd/better-sqlite3-multiple-ciphers/releases/download/v8.5.0/better-sqlite3-multiple-ciphers-v8.5.0-electron-v116-win32-arm64.tar.gz
    prebuild-install http 404 https://github.com/m4heshd/better-sqlite3-multiple-ciphers/releases/download/v8.5.0/better-sqlite3-multiple-ciphers-v8.5.0-electron-v116-win32-arm64.tar.gz
    prebuild-install warn install No prebuilt binaries found (target=25.0.1 runtime=electron arch=arm64 libc= platform=win32)
    
                                    command=/Users/user/.nvm/versions/node/v16.16.0/bin/node /Users/user/code/electron-react-boilerplate/release/app/node_modules/prebuild-install/bin.js --platform=win32 --arch=arm64 --target=25.0.1 --runtime=electron --verbose --force

@m4heshd
Copy link
Owner

m4heshd commented Aug 2, 2023

@willemdjong That's expected because we aren't building for Windows on arm since it's not possible to do so at the moment. GitHub doesn't provide arm based runners. You can take a look at their response at actions/runner-images#768. arm64 is only supported using self-hosted runners which aren't free to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved ✔ This issue has been solved / answered
Projects
None yet
Development

No branches or pull requests

2 participants