Merge pull request #1562 from ychin/fix-whatsnew-url-comparison

ychin · web-flow · commit 3710248dbc7e · 2025-02-20T14:47:14.000-08:00
Fix What's New URL checking logic to compare port correctly
diff --git a/src/MacVim/MMWhatsNewController.m b/src/MacVim/MMWhatsNewController.m
@@ -171,7 +171,7 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati
 
     if ([requestURL.scheme isEqual:_whatsNewURL.scheme] &&
         [requestURL.host isEqual:_whatsNewURL.host] &&
-        [requestURL.port isEqual:_whatsNewURL.port] &&
+        requestURL.port.integerValue == _whatsNewURL.port.integerValue &&
         [requestURL.path isEqual:_whatsNewURL.path] &&
         [requestURL.query isEqual:_whatsNewURL.query])
     {

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati`
`171`	`171`
`172`	`172`	`if ([requestURL.scheme isEqual:_whatsNewURL.scheme] &&`
`173`	`173`	`[requestURL.host isEqual:_whatsNewURL.host] &&`
`174`		`- [requestURL.port isEqual:_whatsNewURL.port] &&`
	`174`	`+ requestURL.port.integerValue == _whatsNewURL.port.integerValue &&`
`175`	`175`	`[requestURL.path isEqual:_whatsNewURL.path] &&`
`176`	`176`	`[requestURL.query isEqual:_whatsNewURL.query])`
`177`	`177`	`{`