Skip to content

Commit 5e199f4

Browse files
authored
Merge pull request #1016 from ychin/fix-vim-version-parsing-configure
Fix configure not parsing Vim version correctly
2 parents 3533c60 + 9635255 commit 5e199f4

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

src/auto/configure

+9-3
Original file line numberDiff line numberDiff line change
@@ -14903,10 +14903,16 @@ $as_echo "using default" >&6; }
1490314903
fi
1490414904

1490514905

14906-
vim_short_version_string=`grep 'define.*VIM_VERSION_SHORT' $srcdir/version.h|sed -E -e 's/.*"([0-9.]*)".*/\1/'`
14906+
vim_major_version_string=`grep -m 1 'define.*VIM_VERSION_MAJOR' $srcdir/version.h|sed -E -e 's/^.*([0-9]+).*/\1/'`
14907+
vim_minor_version_string=`grep -m 1 'define.*VIM_VERSION_MINOR' $srcdir/version.h|sed -E -e 's/^.*([0-9]+).*/\1/'`
1490714908
snapshot=`grep -C2 "Add new patch number below this line" $srcdir/version.c|tail -1|sed -E -e 's/^ *([0-9]+),.*/\1/'`
14908-
vim_short_version_string="$vim_short_version_string.$snapshot"
14909-
XCODEFLAGS="$XCODEFLAGS VIM_SHORT_VERSION_STRING=$vim_short_version_string"
14909+
vim_short_version_string="$vim_major_version_string.$vim_minor_version_string.$snapshot"
14910+
14911+
if echo "$vim_short_version_string" | grep -q "^\d\+\.\d\+\.\d\+$"; then
14912+
XCODEFLAGS="$XCODEFLAGS VIM_SHORT_VERSION_STRING=$vim_short_version_string"
14913+
else
14914+
as_fn_error $? "could not parse Vim version: $vim_short_version_string" "$LINENO" 5
14915+
fi
1491014916

1491114917

1491214918
fi

src/configure.ac

+9-3
Original file line numberDiff line numberDiff line change
@@ -4543,10 +4543,16 @@ if test "x$MACOS_X" = "xyes"; then
45434543
[ AC_MSG_RESULT(using default) ])
45444544

45454545
dnl Set CFBundleShortVersionString of Info.plist
4546-
vim_short_version_string=`grep 'define.*VIM_VERSION_SHORT' $srcdir/version.h|sed -E -e 's/.*"([[0-9.]]*)".*/\1/'`
4546+
vim_major_version_string=`grep -m 1 'define.*VIM_VERSION_MAJOR' $srcdir/version.h|sed -E -e 's/^.*([[0-9]]+).*/\1/'`
4547+
vim_minor_version_string=`grep -m 1 'define.*VIM_VERSION_MINOR' $srcdir/version.h|sed -E -e 's/^.*([[0-9]]+).*/\1/'`
45474548
snapshot=`grep -C2 "Add new patch number below this line" $srcdir/version.c|tail -1|sed -E -e 's/^ *([[0-9]]+),.*/\1/'`
4548-
vim_short_version_string="$vim_short_version_string.$snapshot"
4549-
XCODEFLAGS="$XCODEFLAGS VIM_SHORT_VERSION_STRING=$vim_short_version_string"
4549+
vim_short_version_string="$vim_major_version_string.$vim_minor_version_string.$snapshot"
4550+
4551+
if echo "$vim_short_version_string" | grep -q "^\d\+\.\d\+\.\d\+$"; then
4552+
XCODEFLAGS="$XCODEFLAGS VIM_SHORT_VERSION_STRING=$vim_short_version_string"
4553+
else
4554+
AC_MSG_ERROR(could not parse Vim version: $vim_short_version_string)
4555+
fi
45504556

45514557
AC_SUBST(XCODEFLAGS)
45524558
fi

0 commit comments

Comments
 (0)