Skip to content

Commit e4ea426

Browse files
Bump golang from 1.18.5 to 1.19.0 (#19)
* Bump golang from 1.18.5 to 1.19.0 Bumps golang from 1.18.5 to 1.19.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update go.mod * Update ci * Update commets Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marat Reymers <[email protected]>
1 parent 8d32c2f commit e4ea426

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- uses: actions/checkout@v3
2626
- uses: actions/setup-go@v3
2727
with:
28-
go-version: "1.x"
28+
go-version: "1.19.0"
2929
- name: Debug with tmate SSH if enabled
3030
if: ${{ github.event_name == 'workflow_dispatch' && inputs.debug_ssh }}
3131
uses: mxschmitt/action-tmate@v3
@@ -38,7 +38,7 @@ jobs:
3838
- uses: actions/checkout@v3
3939
- uses: actions/setup-go@v3
4040
with:
41-
go-version: "1.x"
41+
go-version: "1.19.0"
4242
- uses: golangci/golangci-lint-action@v3
4343
with:
4444
version: "v1.48.0" # update together with Dockerfile.dev
@@ -50,5 +50,5 @@ jobs:
5050
- uses: actions/checkout@v3
5151
- uses: actions/setup-go@v3
5252
with:
53-
go-version: "1.x"
53+
go-version: "1.19.0"
5454
- run: make check-tidy

Dockerfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.18.5 AS go
1+
FROM golang:1.19.0 AS go
22

33
# update together with .github/workflows/ci.yml
44
FROM golangci/golangci-lint:v1.48.0 AS linter

async.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ func NewExecutor() *Executor {
3636
}
3737

3838
// Register returns a handler to call a method on the receiver.
39-
// The handler should be registered in jobs processor.
39+
// The handler should be registered in a jobs processor.
4040
//
4141
// Method is a func that takes receiver as the first input parameter.
42-
// The next input parameter may optionally be context.Context.
42+
// The next input parameter may optionally be [context.Context].
4343
// It optionally may return an error (or a type implementing error interface).
4444
//
4545
// Receiver should have the same type as the first parameter of the method.
@@ -115,7 +115,7 @@ func (e *Executor) Register( //nolint:gocognit // TODO: simplify
115115

116116
// Prepare returns jobName and marshaled args to be enqueued.
117117
//
118-
// Arguments are serialized to be saved inside jobs storage.
118+
// Arguments are serialized to be saved inside a jobs storage.
119119
// It is a bad practice to use domain types as a transport ones directly.
120120
// So library limits allowed types as much as possible.
121121
// However, it still may be error-prone, see test "using iota is dangerous".

async_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ func TestExecutor(t *testing.T) {
2424
executor := async.NewExecutor()
2525
_, err := executor.Register("job", domainService, DomainService.Struct__MyEnum__Nothing)
2626
require.NoError(t, err)
27-
// Under the hood MyEnumB is converted to `2` and is stored for the future execution.
28-
// If someone adds/removes enum const before MyEnumB, it changes numbering (actual values of enums).
29-
// It means that once job enqueued with argument `2` (meaning MyEnumB) will be executed with argument 2.
30-
// But now it means not MyEnumB, but some different enum const.
27+
// Under the hood [MyEnumB] is converted to `2` and is stored for the future execution.
28+
// If someone adds/removes enum const before [MyEnumB], it changes numbering (actual values of enums).
29+
// It means that once job enqueued with argument `2` (meaning [MyEnumB]) will be executed with argument 2.
30+
// But now it means not [MyEnumB], but some different enum const.
3131
_, args, err := executor.Prepare(DomainService.Struct__MyEnum__Nothing, MyEnumB)
3232
require.NoError(t, err)
3333
assert.JSONEq(t, `{"arg0":2,"type0":"int"}`, string(args))

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/maratori/async
22

3-
go 1.18
3+
go 1.19
44

55
require (
66
github.com/pkg/errors v0.9.1

0 commit comments

Comments
 (0)