Skip to content

Commit 2ffeeba

Browse files
marco-cmarco-c
committed
Bug 1569735. Move almost all uses of binaryNames out of Bindings.conf and into .webidl files. r=peterv
The one exception, apart from tests, is a place where the constructor is being renamed, because there is no way to support that syntactically yet. There will be if whatwg/webidl#636 is fixed. Differential Revision: https://phabricator.services.mozilla.com/D39792 UltraBlame original commit: fb9468d66df42cf6e09d288e53fafcd9e7bdcbd4
1 parent 4ec488c commit 2ffeeba

21 files changed

+245
-422
lines changed

‎dom/bindings/Bindings.conf

Lines changed: 0 additions & 343 deletions
Large diffs are not rendered by default.

‎dom/bindings/Configuration.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -3756,34 +3756,6 @@
37563756
}
37573757
)
37583758

3759-
self
3760-
.
3761-
_binaryNames
3762-
.
3763-
setdefault
3764-
(
3765-
'
3766-
__legacycaller
3767-
'
3768-
'
3769-
LegacyCall
3770-
'
3771-
)
3772-
3773-
self
3774-
.
3775-
_binaryNames
3776-
.
3777-
setdefault
3778-
(
3779-
'
3780-
__stringifier
3781-
'
3782-
'
3783-
Stringify
3784-
'
3785-
)
3786-
37873759
if
37883760
not
37893761
self
@@ -3902,6 +3874,34 @@
39023874
]
39033875
)
39043876

3877+
self
3878+
.
3879+
_binaryNames
3880+
.
3881+
setdefault
3882+
(
3883+
'
3884+
__legacycaller
3885+
'
3886+
'
3887+
LegacyCall
3888+
'
3889+
)
3890+
3891+
self
3892+
.
3893+
_binaryNames
3894+
.
3895+
setdefault
3896+
(
3897+
'
3898+
__stringifier
3899+
'
3900+
'
3901+
Stringify
3902+
'
3903+
)
3904+
39053905
self
39063906
.
39073907
prototypeChain

‎dom/webidl/AudioNode.webidl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,13 +360,23 @@ channelCount
360360
;
361361
[
362362
SetterThrows
363+
BinaryName
364+
=
365+
"
366+
channelCountModeValue
367+
"
363368
]
364369
attribute
365370
ChannelCountMode
366371
channelCountMode
367372
;
368373
[
369374
SetterThrows
375+
BinaryName
376+
=
377+
"
378+
channelInterpretationValue
379+
"
370380
]
371381
attribute
372382
ChannelInterpretation

‎dom/webidl/CSSStyleSheet.webidl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,11 @@ StyleSheet
136136
{
137137
[
138138
Pure
139+
BinaryName
140+
=
141+
"
142+
DOMOwnerRule
143+
"
139144
]
140145
readonly
141146
attribute

‎dom/webidl/CanvasRenderingContext2D.webidl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,11 @@ Deprecated
367367
"
368368
PrefixedImageSmoothingEnabled
369369
"
370+
BinaryName
371+
=
372+
"
373+
imageSmoothingEnabled
374+
"
370375
]
371376
attribute
372377
boolean

‎dom/webidl/DOMException.webidl

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,13 @@ by
434434
the
435435
thrower
436436
.
437+
[
438+
BinaryName
439+
=
440+
"
441+
messageMoz
442+
"
443+
]
437444
readonly
438445
attribute
439446
DOMString
@@ -548,6 +555,13 @@ by
548555
the
549556
thrower
550557
.
558+
[
559+
BinaryName
560+
=
561+
"
562+
messageMoz
563+
"
564+
]
551565
readonly
552566
attribute
553567
DOMString

‎dom/webidl/DynamicsCompressorNode.webidl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,13 @@ attack
251251
/
252252
in
253253
Seconds
254+
[
255+
BinaryName
256+
=
257+
"
258+
getRelease
259+
"
260+
]
254261
readonly
255262
attribute
256263
AudioParam

‎dom/webidl/FetchEvent.webidl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,11 @@ ExtendableEvent
147147
{
148148
[
149149
SameObject
150+
BinaryName
151+
=
152+
"
153+
request_
154+
"
150155
]
151156
readonly
152157
attribute

‎dom/webidl/HTMLTextAreaElement.webidl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,13 @@ EmptyString
367367
DOMString
368368
value
369369
;
370+
[
371+
BinaryName
372+
=
373+
"
374+
getTextLength
375+
"
376+
]
370377
readonly
371378
attribute
372379
unsigned

‎dom/webidl/IDBCursor.webidl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,13 @@ IDBIndex
167167
)
168168
source
169169
;
170+
[
171+
BinaryName
172+
=
173+
"
174+
getDirection
175+
"
176+
]
170177
readonly
171178
attribute
172179
IDBCursorDirection

‎dom/webidl/IDBIndex.webidl

Lines changed: 48 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -421,44 +421,53 @@ partial
421421
interface
422422
IDBIndex
423423
{
424-
[
425-
Throws
426-
]
427-
IDBRequest
424+
/
425+
/
426+
If
427+
we
428+
decide
429+
to
430+
add
431+
use
432+
counters
433+
for
434+
the
428435
mozGetAll
429-
(
430-
optional
431-
any
432-
key
433-
optional
434-
[
435-
EnforceRange
436-
]
437-
unsigned
438-
long
439-
limit
440-
)
441-
;
442-
[
443-
Throws
444-
]
445-
IDBRequest
436+
/
446437
mozGetAllKeys
447-
(
448-
optional
449-
any
450-
key
451-
optional
452-
[
453-
EnforceRange
454-
]
455-
unsigned
456-
long
457-
limit
458-
)
459-
;
438+
/
439+
/
440+
functions
441+
we
442+
'
443+
ll
444+
need
445+
to
446+
pull
447+
them
448+
out
449+
into
450+
sepatate
451+
operations
452+
/
453+
/
454+
with
455+
a
456+
BinaryName
457+
mapping
458+
to
459+
the
460+
same
461+
underlying
462+
implementation
463+
.
460464
[
461465
Throws
466+
Alias
467+
=
468+
"
469+
mozGetAll
470+
"
462471
]
463472
IDBRequest
464473
getAll
@@ -477,6 +486,11 @@ limit
477486
;
478487
[
479488
Throws
489+
Alias
490+
=
491+
"
492+
mozGetAllKeys
493+
"
480494
]
481495
IDBRequest
482496
getAllKeys

‎dom/webidl/IDBObjectStore.webidl

Lines changed: 44 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -352,26 +352,53 @@ values
352352
for
353353
given
354354
keys
355-
[
356-
Throws
357-
]
358-
IDBRequest
355+
/
356+
/
357+
If
358+
we
359+
decide
360+
to
361+
add
362+
use
363+
a
364+
counter
365+
for
366+
the
359367
mozGetAll
360-
(
361-
optional
362-
any
363-
key
364-
optional
365-
[
366-
EnforceRange
367-
]
368-
unsigned
369-
long
370-
limit
371-
)
372-
;
368+
function
369+
we
370+
'
371+
ll
372+
need
373+
/
374+
/
375+
to
376+
pull
377+
it
378+
out
379+
into
380+
a
381+
sepatate
382+
operation
383+
with
384+
a
385+
BinaryName
386+
mapping
387+
to
388+
the
389+
/
390+
/
391+
same
392+
underlying
393+
implementation
394+
.
373395
[
374396
Throws
397+
Alias
398+
=
399+
"
400+
mozGetAll
401+
"
375402
]
376403
IDBRequest
377404
getAll

‎dom/webidl/ImageCapture.webidl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,13 @@ attribute
185185
PhotoSettingsOptions
186186
photoSettingsOptions
187187
;
188+
[
189+
BinaryName
190+
=
191+
"
192+
GetVideoStreamTrack
193+
"
194+
]
188195
readonly
189196
attribute
190197
MediaStreamTrack

‎dom/webidl/MediaStreamAudioDestinationNode.webidl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,13 @@ MediaStreamAudioDestinationNode
168168
:
169169
AudioNode
170170
{
171+
[
172+
BinaryName
173+
=
174+
"
175+
DOMStream
176+
"
177+
]
171178
readonly
172179
attribute
173180
MediaStream

0 commit comments

Comments
 (0)