Add host address to BindTransportException message

When bind fails, show the host address in addition to the port. This
helps debugging cases with wrong "network.host" values.

Closes elastic#48001

Author: mariaral

modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpServerTransportTests.java

@@ -195,11 +195,17 @@ public void testBindUnavailableAddress() {
                 xContentRegistry(), new NullDispatcher())) {
             transport.start();
             TransportAddress remoteAddress = randomFrom(transport.boundAddress().boundAddresses());
-            Settings settings = Settings.builder().put("http.port", remoteAddress.getPort()).build();
+            Settings settings = Settings.builder()
+                .put("http.port", remoteAddress.getPort())
+                .put("network.host", remoteAddress.getAddress())
+                .build();
             try (Netty4HttpServerTransport otherTransport = new Netty4HttpServerTransport(settings, networkService, bigArrays, threadPool,
                     xContentRegistry(), new NullDispatcher())) {
                 BindHttpException bindHttpException = expectThrows(BindHttpException.class, otherTransport::start);
-                assertEquals("Failed to bind to [" + remoteAddress.getPort() + "]", bindHttpException.getMessage());
+                assertEquals(
+                    "Failed to bind to [" + remoteAddress.getPort() + "] on " + remoteAddress.address().getAddress().getHostAddress(),
+                    bindHttpException.getMessage()
+                );
             }
         }
     }

plugins/transport-nio/src/test/java/org/elasticsearch/http/nio/NioHttpServerTransportTests.java

@@ -190,11 +190,17 @@ public void testBindUnavailableAddress() {
             threadPool, xContentRegistry(), new NullDispatcher(), new NioGroupFactory(Settings.EMPTY, logger))) {
             transport.start();
             TransportAddress remoteAddress = randomFrom(transport.boundAddress().boundAddresses());
-            Settings settings = Settings.builder().put("http.port", remoteAddress.getPort()).build();
+            Settings settings = Settings.builder()
+                .put("http.port", remoteAddress.getPort())
+                .put("network.host", remoteAddress.getAddress())
+                .build();
             try (NioHttpServerTransport otherTransport = new NioHttpServerTransport(settings, networkService, bigArrays, pageRecycler,
                 threadPool, xContentRegistry(), new NullDispatcher(), new NioGroupFactory(Settings.EMPTY, logger))) {
                 BindHttpException bindHttpException = expectThrows(BindHttpException.class, () -> otherTransport.start());
-                assertEquals("Failed to bind to [" + remoteAddress.getPort() + "]", bindHttpException.getMessage());
+                assertEquals(
+                    "Failed to bind to [" + remoteAddress.getPort() + "] on " + remoteAddress.address().getAddress().getHostAddress(),
+                    bindHttpException.getMessage()
+                );
             }
         }
     }

server/src/main/java/org/elasticsearch/http/AbstractHttpServerTransport.java

@@ -174,7 +174,10 @@ private TransportAddress bindAddress(final InetAddress hostAddress) {
             return true;
         });
         if (!success) {
-            throw new BindHttpException("Failed to bind to [" + port.getPortRangeString() + "]", lastException.get());
+            throw new BindHttpException(
+                "Failed to bind to [" + port.getPortRangeString() + "] on " + hostAddress.getHostAddress(),
+                lastException.get()
+            );
         }
 
         if (logger.isDebugEnabled()) {

server/src/main/java/org/elasticsearch/transport/TcpTransport.java

@@ -377,7 +377,10 @@ private InetSocketAddress bindToPort(final String name, final InetAddress hostAd
                 return true;
             });
             if (!success) {
-                throw new BindTransportException("Failed to bind to [" + port + "]", lastException.get());
+                throw new BindTransportException(
+                    "Failed to bind to [" + port + "] on " + hostAddress.getHostAddress(),
+                    lastException.get()
+                );
             }
         } finally {
             closeLock.writeLock().unlock();

test/framework/src/main/java/org/elasticsearch/transport/AbstractSimpleTransportTestCase.java

@@ -2698,13 +2698,15 @@ public void testProfilesIncludesDefault() {
 
     public void testBindUnavailableAddress() {
         int port = serviceA.boundAddress().publishAddress().getPort();
+        String address = serviceA.boundAddress().publishAddress().getAddress();
         Settings settings = Settings.builder()
             .put(Node.NODE_NAME_SETTING.getKey(), "foobar")
+            .put(TransportSettings.HOST.getKey(), address)
             .put(TransportSettings.PORT.getKey(), port)
             .build();
         BindTransportException bindTransportException = expectThrows(BindTransportException.class,
             () -> buildService("test", Version.CURRENT, settings));
-        assertEquals("Failed to bind to ["+ port + "]", bindTransportException.getMessage());
+        assertEquals("Failed to bind to [" + port + "] on " + address, bindTransportException.getMessage());
     }
 
     public void testChannelCloseWhileConnecting() {