Skip to content

Commit eda4390

Browse files
authored
Merge pull request #2 from jsvd/pr_1208_addition
fix tests to not require custom es ruby code
2 parents 8c73056 + 1369716 commit eda4390

File tree

7 files changed

+12
-147
lines changed

7 files changed

+12
-147
lines changed

spec/es_spec_helper.rb

+4-20
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
require_relative './spec_helper'
22

33
require 'elasticsearch'
4-
require_relative "support/elasticsearch/api/actions/delete_ilm_policy"
5-
require_relative "support/elasticsearch/api/actions/get_alias"
6-
require_relative "support/elasticsearch/api/actions/put_alias"
7-
require_relative "support/elasticsearch/api/actions/get_ilm_policy"
8-
require_relative "support/elasticsearch/api/actions/put_ilm_policy"
94

105
require 'json'
116
require 'cabin'
@@ -130,31 +125,20 @@ def get_cluster_settings(client)
130125
end
131126

132127
def get_policy(client, policy_name)
133-
client.get_ilm_policy(name: policy_name)
128+
client.index_lifecycle_management.get_lifecycle(policy: policy_name)
134129
end
135130

136131
def put_policy(client, policy_name, policy)
137-
client.put_ilm_policy({:name => policy_name, :body=> policy})
138-
end
139-
140-
def put_alias(client, the_alias, index)
141-
body = {
142-
"aliases" => {
143-
index => {
144-
"is_write_index"=> true
145-
}
146-
}
147-
}
148-
client.put_alias({name: the_alias, body: body})
132+
client.index_lifecycle_management.put_lifecycle({:policy => policy_name, :body=> policy})
149133
end
150134

151135
def clean_ilm(client)
152-
client.get_ilm_policy.each_key { |key| client.delete_ilm_policy(name: key) if key =~ /logstash-policy/ }
136+
client.index_lifecycle_management.get_lifecycle.each_key { |key| client.index_lifecycle_management.delete_lifecycle(policy: key) if key =~ /logstash-policy/ }
153137
end
154138

155139
def supports_ilm?(client)
156140
begin
157-
client.get_ilm_policy
141+
client.index_lifecycle_management.get_lifecycle
158142
true
159143
rescue
160144
false

spec/integration/outputs/ilm_spec.rb

+8-7
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@
282282
subject.register
283283
sleep(1)
284284
expect(@es.indices.exists_alias(name: "logstash")).to be_truthy
285-
expect(@es.get_alias(name: "logstash")).to include("logstash-000001")
285+
expect(@es.indices.get_alias(name: "logstash")).to include("logstash-000001")
286286
end
287287
end
288288

@@ -298,7 +298,7 @@
298298
subject.register
299299
sleep(1)
300300
expect(@es.indices.exists_alias(name: "logstash")).to be_truthy
301-
expect(@es.get_alias(name: "logstash")).to include("logstash-#{todays_date}-000001")
301+
expect(@es.indices.get_alias(name: "logstash")).to include("logstash-#{todays_date}-000001")
302302
end
303303

304304
it 'should ingest into a single index' do
@@ -374,7 +374,7 @@
374374
subject.register
375375
sleep(1)
376376
expect(@es.indices.exists_alias(name: expected_index)).to be_truthy
377-
expect(@es.get_alias(name: expected_index)).to include("#{expected_index}-#{todays_date}-000001")
377+
expect(@es.indices.get_alias(name: expected_index)).to include("#{expected_index}-#{todays_date}-000001")
378378
end
379379

380380
it 'should write the ILM settings into the template' do
@@ -443,17 +443,18 @@
443443
subject.register
444444
sleep(1)
445445
expect(@es.indices.exists_alias(name: ilm_rollover_alias)).to be_truthy
446-
expect(@es.get_alias(name: ilm_rollover_alias)).to include("#{ilm_rollover_alias}-#{todays_date}-000001")
446+
expect(@es.indices.get_alias(name: ilm_rollover_alias)).to include("#{ilm_rollover_alias}-#{todays_date}-000001")
447447
end
448448

449449
context 'when the custom rollover alias already exists' do
450450
it 'should ignore the already exists error' do
451451
expect(@es.indices.exists_alias(name: ilm_rollover_alias)).to be_falsey
452-
put_alias(@es, "#{ilm_rollover_alias}-#{todays_date}-000001", ilm_rollover_alias)
452+
@es.indices.create(index: "#{ilm_rollover_alias}-#{todays_date}-000001")
453+
@es.indices.put_alias(name: ilm_rollover_alias, index: "#{ilm_rollover_alias}-#{todays_date}-000001")
453454
expect(@es.indices.exists_alias(name: ilm_rollover_alias)).to be_truthy
454455
subject.register
455456
sleep(1)
456-
expect(@es.get_alias(name: ilm_rollover_alias)).to include("#{ilm_rollover_alias}-#{todays_date}-000001")
457+
expect(@es.indices.get_alias(name: ilm_rollover_alias)).to include("#{ilm_rollover_alias}-#{todays_date}-000001")
457458
end
458459

459460
end
@@ -536,4 +537,4 @@
536537
def get_expected_error_class
537538
return Elastic::Transport::Transport::Errors::NotFound if elastic_ruby_v8_client_available?
538539
Elasticsearch::Transport::Transport::Errors::NotFound
539-
end
540+
end

spec/support/elasticsearch/api/actions/delete_ilm_policy.rb

-19
This file was deleted.

spec/support/elasticsearch/api/actions/get_alias.rb

-18
This file was deleted.

spec/support/elasticsearch/api/actions/get_ilm_policy.rb

-18
This file was deleted.

spec/support/elasticsearch/api/actions/put_alias.rb

-24
This file was deleted.

spec/support/elasticsearch/api/actions/put_ilm_policy.rb

-41
This file was deleted.

0 commit comments

Comments
 (0)