Skip to content

[Color] app is not expressive #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manabu-nakamura opened this issue Mar 25, 2025 · 4 comments · May be fixed by #4705
Open

[Color] app is not expressive #4704

manabu-nakamura opened this issue Mar 25, 2025 · 4 comments · May be fixed by #4705
Assignees
@pekingme
Labels
bug Expressive Feature: Color

Comments

@manabu-nakamura
Copy link
Contributor

Description: The app is not expressive.
Image
The catalog app is expressive.
Image

Expected behavior: The app is expressive.
Image

Source code:

<manifest
    xmlns:android="http://schemas.android.com/apk/res/android">
    <application
        ...
        android:theme="@style/Theme.Material3Expressive.DynamicColors.DayNight">
        ...
    </application>
</manifest>

Minimal sample app repro: Test16.zip

Android API version: 34

Material Library version: 1.13.0-alpha12

Device: Android Emulator 35.4.9
@manabu-nakamura manabu-nakamura linked a pull request Mar 25, 2025 that will close this issue
Open
@bubbleguuum
Copy link

Looks like ThemeOverlay.Material3Expressive.DynamicColors.Light and ThemeOverlay.Material3Expressive.DynamicColors.Dark should get the same treatment.

@pekingme
Copy link
Contributor

@manabu-nakamura Are you referring to the colors or the button corners? Btw, you should use the Theme.Material3Expressive.DayNight in your manifest to get the complete theme.

@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Mar 27, 2025 •
edited
Loading

Are you referring to the colors or the button corners?

Both.

Btw, you should use the Theme.Material3Expressive.DayNight in your manifest to get the complete theme.

I use the Theme.Material3.DynamicColors.DayNight to make the app dynamic color.
https://developer.android.com/develop/ui/views/appwidgets/enhance#dynamic-colors
Is this wrong?

@manabu-nakamura
Copy link
Contributor Author

Do we have to use the Theme.Material3Expressive.DayNight and DynamicColors.applyToActivityIfAvailable(this)?
Do we have to use the Theme.Material3.DayNight and DynamicColors.applyToActivityIfAvailable(this)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pekingme pekingme

Labels
bug Expressive Feature: Color
Projects
None yet
Milestone
No milestone
4 participants
@bubbleguuum @paulfthomas @pekingme @manabu-nakamura