Skip to content

Commit b9e5dd7

Browse files
committed
Rename PHP_IMAGE to PHP_VERSION
1 parent 7267177 commit b9e5dd7

File tree

5 files changed

+23
-47
lines changed

5 files changed

+23
-47
lines changed

.env.dist

+2-6
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,9 @@ MYSQL_USER=wordpress
55
MYSQL_PASSWORD=wordpress
66

77
# WordPress
8-
if [ -z "$WP_VERSION" ]; then
9-
WP_VERSION=5.6
10-
fi
8+
WP_VERSION=5.6
119
WP_DB_USER=wordpress
1210
WP_DB_PASSWORD=wordpress
1311

1412
# PHP
15-
if [ -z "$PHP_IMAGE" ]; then
16-
PHP_IMAGE=php7.4-apache
17-
fi
13+
PHP_VERSION=php7.4-apache

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104

105105
- name: E2E tests with Docker (7.3, WordPress 5.2)
106106
php: "7.3"
107-
env: NODE_ENV=teste2e PHP_IMAGE=php7.3-apache WP_VERSION=5.2
107+
env: NODE_ENV=teste2e PHP_VERSION=php7.3-apache WP_VERSION=5.2
108108
before_install:
109109
- unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD
110110
- nvm install

bin/local-dev/wordpress/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
# limitations under the License.
1414

1515
ARG WP_VERSION
16-
ARG PHP_IMAGE
16+
ARG PHP_VERSION
1717

18-
FROM wordpress:${WP_VERSION}-${PHP_IMAGE}
18+
FROM wordpress:${WP_VERSION}-${PHP_VERSION}
1919

2020
ENV NODE_VERSION 10.18.1
2121
ENV YARN_VERSION 1.21.1

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ services:
3535
context: ./bin/local-dev/wordpress
3636
args:
3737
WP_VERSION: ${WP_VERSION}
38-
PHP_IMAGE: ${PHP_IMAGE}
38+
PHP_VERSION: ${PHP_VERSION}
3939
depends_on:
4040
- mysql
4141
ports:

package-lock.json

+17-37
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)