Skip to content

Fix problems with \middle. #1023 #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2016
Merged

Fix problems with \middle. #1023 #1508

merged 1 commit into from
Jun 8, 2016

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 7, 2016

Surround \middle with OPEN and CLOSE TeXAtoms, so that the spacing will be consistent with TeX's version (e.g., \mathrel{}\middle|\mathrel{} will produce the right spacing). As a side effect, this resolves the problem with the quotes, sot this resolves issue #1023.

…ll be consistent with TeX's version (e.g., \mathrel{}\middle|\mathrel{} will produce the right spacing). As a side effect, this resolves the problem with the quotes, sot this resolves issue mathjax#1023.
@pkra pkra added this to the MathJax v2.x.x milestone Jun 7, 2016
@zorkow
Copy link
Member

zorkow commented Jun 8, 2016

lgtm.

Question: What happens on a TEX.ERROR? Will that lead to a math processing error?

@dpvc
Copy link
Member Author

dpvc commented Jun 8, 2016

What happens on a TEX.Error?

The TeX input processor will stop parsing the expression and produce an merror element that includes the error message. If the noErrors extension is in play, then the error causes the original TeX code to be displayed rather than the error message (this was requested by AMS long ago, though personally I think it is a mistake to have it in the combined config files).

Will that lead to a math processing error?

No. Those should only come from errors in the MathJax javascript code, not from errors in the user input (which should be reported like the one at line 1340 here).

@dpvc dpvc merged commit 9779801 into mathjax:develop Jun 8, 2016
@dpvc dpvc deleted the issue1023 branch June 8, 2016 11:13
@pkra
Copy link
Contributor

pkra commented Jun 8, 2016

though personally I think it is a mistake to have it in the combined config files).

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants