Make CHTML mglyph scale image size by hand. mathjax/MathJax-node#241 #1512
Conversation
…dth and offsetHeight, since those cause reflow. This also makes it work in mathjax-node. Resolves mathjax/MathJax-node#241.
| var WW = W, HH = H; | ||
| if (w !== "") {W = this.CHTMLlength2em(w,WW); H = (WW ? W/WW * HH : 0)} | ||
| if (h !== "") {H = this.CHTMLlength2em(h,HH); if (w === "") W = (HH ? H/HH * WW : 0)} | ||
| img.style.width = CHTML.Em(W); bbox.w = bbox.r = W; |
There was a problem hiding this comment.
So these will fire, even if w,h are undefined? Is that intended?
There was a problem hiding this comment.
For future reference: The code would be a lot easier to read if it were spread out a bit and had more descriptive var names. In particular cap vs non-cap is difficult to parse.
There was a problem hiding this comment.
So these will fire, even if w,h are undefined?
I'm not sure which line "these" refer to. Note that w and h are never undefined, though they can be empty (they come from the getValues() method, and since the defaults for these are "", if there is no explicit value, those will eventually be found, so they are always defined).
If you mean the style settings in line 68, these use the values of W and H. These come from the img width and height, and since the image has loaded when these lines run, they are always defined. Even in jsdom, they are defined (but 0, so in mathjax-node, you are expected to use explicit width and height).
Does that cover your concerns?
|
Thanks for the explanation. |
Make CHTML
mglyphscale image size by hand rather than usingoffsetWidthandoffsetHeight, since those cause reflow. This also makes it work in mathjax-node. Resolves mathjax/MathJax-node#241.