Skip to content

Add Contrib to the Ajax paths. #1519 #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2016
Merged

Add Contrib to the Ajax paths. #1519 #1522

merged 1 commit into from
Jun 15, 2016

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 14, 2016

Add [Contrib] to the Ajax paths. Resolves issue #1519.

@pkra pkra added this to the MathJax v2.x.x milestone Jun 15, 2016
@pkra
Copy link
Contributor

pkra commented Jun 15, 2016

LGTM.

Should we consider enforcing https in v3.0? Right now, this would break very old systems like WinXP with outdated cert infrastructures but perhaps it is time for 3.0.

@dpvc
Copy link
Member Author

dpvc commented Jun 15, 2016

Is there anything really that needs to be done differently for https from http? If the only accommodation that needs to be made is to check the protocol now and then, I don't see the harm in doing so. But I don't have any strong feelings about it.

@dpvc dpvc merged commit 6e3b671 into mathjax:develop Jun 15, 2016
@dpvc dpvc deleted the issue1519 branch June 15, 2016 12:44
@pkra
Copy link
Contributor

pkra commented Jun 15, 2016

If the only accommodation that needs to be made is to check the protocol now and then, I don't see the harm in doing so.

Right. I suppose if the CDN always loaded via https, then at least it can't be a point of attack. Which, arguably, is very little if the site is on http.

But I don't have any strong feelings about it.

Me neither.

But now I spotted a typo!

pkra
pkra reviewed Jun 15, 2016
View reviewed changes
unpacked/MathJax.js
@@ -659,6 +659,8 @@ MathJax.cdnFileVersions = {}; // can be used to specify revisions for individua

var PATH = {};
PATH[BASENAME] = ""; // empty path gets the root URL
PATH.Contrib = (String(location.protocal).match(/^https?:/) ? "" : "http:") +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location.protocol?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching that before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MathJax v2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @pkra