Skip to content

Fix determination of line-breaing parent element. #1548. #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2016

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 4, 2016

Fix determination of line-breaking parent element. It was moving too high in some cases. E.g., in

  <mrow>
    <msqrt>
      ...
    </msqrt>
  </mrow>

the inferred mrow in the msqrt was stepping out to the msqrt (correctly) but then stepped out to the mrow and its parent (since it was an mrow with one child). The change to parent.isEmbellished() causes the stepping out to occur only when the outer mrow represents an embellished operator. (We only want isTop to be true in that case.)

Resolves issue #1548.

@pkra pkra added this to the MathJax v2.x.x milestone Jul 5, 2016
@zorkow
Copy link
Member

zorkow commented Jul 23, 2016

lgtm.

@dpvc dpvc merged commit 0940fce into mathjax:develop Jul 23, 2016
@dpvc dpvc deleted the issue1548 branch July 23, 2016 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants