Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Axisoff #180

Closed
brk030 opened this issue Jun 18, 2020 · 3 comments
Closed

Question Axisoff #180

brk030 opened this issue Jun 18, 2020 · 3 comments
Labels
bug Something isn't working question Further information is requested released code merged into repo AND released to Pypi

Comments

@brk030
Copy link

brk030 commented Jun 18, 2020

Hello,

so I just tried using the argument axisoff = True. However, it zooms in the original picture making it look different. Attached you can find both versions. Why does that happen? Where is my mistake?

Thank you in advance and best regards.
Screenshot 2020-06-18 at 17 33 18
Screenshot 2020-06-18 at 17 33 38

@brk030 brk030 added the question Further information is requested label Jun 18, 2020
@DanielGoldfarb
Copy link
Collaborator

DanielGoldfarb commented Jun 18, 2020

When axisoff was originally requested, by several people, they wanted also axisoff to show a tight layout. At the time, kwarg tight_layout was not yet available for mplfinance. This is why axisoff is effectively automatically doing tight_layout at the same time. Unfortunately there is presently no way around this unless you want to tweak the code.

In the meantime, I think for the next release, I will make axisoff and tight_layout more independent ... although I may decide to still have axisoff default to tight_layout=True, but the user can override it with tight_layout=False; not sure yet, but at the very least you will be able to control it one way or the other.

@DanielGoldfarb
Copy link
Collaborator

Since coupling between otherwise independent kwargs is, imho, not good, I have decided to completely remove the coupling between axisoff and tight_layout and make these two kwargs completely independent of each other. The code has been changed in my fork and I expect to enter a PR (along with some other enehancements) sometime in the next few days.

@DanielGoldfarb DanielGoldfarb added released code merged into repo AND released to Pypi and removed in progress labels Jun 24, 2020
@DanielGoldfarb
Copy link
Collaborator

pip install --upgrade mplfinance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested released code merged into repo AND released to Pypi
Projects
None yet
Development

No branches or pull requests

2 participants