Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect linestyles character for dotted #186

Closed
amiaty opened this issue Jun 22, 2020 · 2 comments
Closed

Incorrect linestyles character for dotted #186

amiaty opened this issue Jun 22, 2020 · 2 comments
Assignees
@DanielGoldfarb
Labels
bug Something isn't working released code merged into repo AND released to Pypi

Comments

@amiaty
Copy link
Contributor

amiaty commented Jun 22, 2020

Hello,

I think in valid_linestyles, '.' should change to ':', since mplfinance sent it to matplotlib, and matplotlib throws an error.

the correct character for dotted is ':'

https://matplotlib.org/3.1.0/api/_as_gen/matplotlib.lines.Line2D.html#matplotlib.lines.Line2D.set_linestyle
@amiaty amiaty added the bug Something isn't working label Jun 22, 2020
@DanielGoldfarb DanielGoldfarb self-assigned this Jun 22, 2020
@DanielGoldfarb
Copy link
Collaborator

Amir,
Thanks for pointing this out.
All the best. --Daniel

@DanielGoldfarb DanielGoldfarb added released code merged into repo AND released to Pypi and removed in progress labels Jun 24, 2020
@DanielGoldfarb
Copy link
Collaborator

pip install --upgrade mplfinance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielGoldfarb DanielGoldfarb

Labels
bug Something isn't working released code merged into repo AND released to Pypi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielGoldfarb @amiaty