Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point and figure [pnf] - Reversal param #368

Closed
heytechv opened this issue Apr 1, 2021 · 4 comments · Fixed by #370
Closed

Point and figure [pnf] - Reversal param #368

heytechv opened this issue Apr 1, 2021 · 4 comments · Fixed by #370
Labels
enhancement New feature or request released code merged into repo AND released to Pypi

Comments

@heytechv
Copy link

heytechv commented Apr 1, 2021

Hello,

Is it possible to change the PNF param "reversal" the same way as i can do with "box_size"? Is it even possible?

mpf.plot(df, type='pnf', pnf_params=dict(box_size=7))

@heytechv heytechv added the question Further information is requested label Apr 1, 2021
@DanielGoldfarb
Copy link
Collaborator

Presently the reversal amount is assumed to be 1 box, and not configurable. Do you have any interest in making this enhancement to mplfinance?

@heytechv
Copy link
Author

heytechv commented Apr 2, 2021

I am a TradingView user (where I can configure box size and reversal size separately) and am now trying to implement some indicator in Python but I couldn't find that. Thanks for the answer then.

@coffincw
Copy link
Collaborator

coffincw commented Apr 3, 2021

Hello @HeyTechVideos,

I'll look into implementing the reversal size override this weekend.

@heytechv
Copy link
Author

heytechv commented Apr 5, 2021

Thanks a lot @coffincw!

If you need to, I found a working but outdated (just replace the deprecated .ix() in pandas) PnF chart with a reversal parameter. https://github.com/ChillarAnand/stocktrends/blob/master/stocktrends/indicators.py

Greetings

@DanielGoldfarb DanielGoldfarb added released code merged into repo AND released to Pypi and removed in progress labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released code merged into repo AND released to Pypi
Projects
None yet
3 participants