Skip to content

Commit a793b48

Browse files
committed
Remove Synapse-specific dockerfiles
matrix-org/synapse#12404 moved these to the Synapse repo.
1 parent 2180cc5 commit a793b48

13 files changed

+14
-501
lines changed

.github/workflows/ci.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ jobs:
6868
# Build homeserver image
6969

7070
# Build the base Synapse dockerfile and then build a Complement-specific image from that base.
71-
- run: docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
71+
- run: |
72+
docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
73+
docker build -t homeserver -f docker/complement/Dockerfile docker/compelment
7274
if: ${{ matrix.homeserver == 'Synapse' }}
7375
working-directory: homeserver
7476
env:
7577
DOCKER_BUILDKIT: 1
76-
- run: docker build -t homeserver -f dockerfiles/${{ matrix.homeserver }}.Dockerfile dockerfiles/
77-
if: ${{ matrix.homeserver == 'Synapse' }}
7878
7979
# Build the Complement-specific dendrite image from the dockerfile in the Dendrite repo.
8080
# We don't use the dockerfiles in the Complement repo as they tend to get stale quickly.

README.md

+10-5
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,22 @@ $ COMPLEMENT_BASE_IMAGE=complement-dendrite:latest go test -v ./tests/...
5151

5252
If you're looking to run Complement against a local dev instance of Synapse, see [`matrix-org/synapse` -> `scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh).
5353

54-
If you want to develop Complement tests while working on a local dev instance of Synapse, use the [`scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh) script and set the `COMPLEMENT_DIR` environment variable to the filepath of your local Complement checkout. A regex that matches against test names can also be supplied as an argument to the script, i.e:
54+
If you want to develop Complement tests while working on a local dev instance
55+
of Synapse, use the
56+
[`scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh)
57+
script and set the `COMPLEMENT_DIR` environment variable to the filepath of
58+
your local Complement checkout. Arguments to `go test` can be supplied as an argument to the script, e.g.:
5559

5660
```sh
57-
COMPLEMENT_DIR=/path/to/complement scripts-dev/complement.sh "TestOutboundFederation(Profile|Send)"
61+
COMPLEMENT_DIR=/path/to/complement scripts-dev/complement.sh -run "TestOutboundFederation(Profile|Send)"
5862
```
5963

60-
To run Complement against a specific release of Synapse, set the
61-
`SYNAPSE_VERSION` build argument. For example:
64+
To run Complement against a specific release of Synapse, build the
65+
"complement-synapse" image with a `SYNAPSE_VERSION` build argument. For
66+
example:
6267

6368
```sh
64-
docker build -t complement-synapse:v1.36.0 -f dockerfiles/Synapse.Dockerfile --build-arg=SYNAPSE_VERSION=v1.36.0 dockerfiles
69+
(cd synapse && docker build -t complement-synapse:v1.36.0 -f docker/complement/Dockerfile --build-arg=SYNAPSE_VERSION=v1.36.0 docker/complement)
6570
COMPLEMENT_BASE_IMAGE=complement-synapse:v1.36.0 go test ./tests/...
6671
```
6772

dockerfiles/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ end up copying the Dockerfiles in this directory to their own repository. In an
66
duplication, we now point to dockerfiles in respective repositories rather than have them directly here.
77

88
- Dendrite: https://github.com/matrix-org/dendrite/blob/v0.6.3/build/scripts/Complement.Dockerfile
9-
- Synapse: https://github.com/matrix-org/synapse/blob/v1.52.0/scripts-dev/complement.sh
9+
- Synapse: https://github.com/matrix-org/synapse/blob/develop/docker/complement/Dockerfile

dockerfiles/Synapse.Dockerfile

-36
This file was deleted.

dockerfiles/SynapseWorkers.Dockerfile

-73
This file was deleted.

dockerfiles/keys/README.md

-9
This file was deleted.

dockerfiles/keys/ca.crt

-21
This file was deleted.

dockerfiles/keys/ca.key

-27
This file was deleted.

dockerfiles/synapse/caddy.complement.json

-76
This file was deleted.

0 commit comments

Comments
 (0)