Fix assert of unsafe media api behaviour (#639)

joshqou · web-flow · commit b9ac3c416f0d · 2023-06-15T12:28:01.000+01:00
diff --git a/tests/media_filename_test.go b/tests/media_filename_test.go
@@ -118,7 +118,7 @@ func TestMediaFilenames(t *testing.T) {
 	})
 }
 
-// Returns content disposition information like (inline, filename)
+// Returns content disposition information like (mediatype, filename)
 func downloadForFilename(t *testing.T, c *client.CSAPI, mxcUri string, diffName string) string {
 	t.Helper()
 
@@ -139,8 +139,8 @@ func downloadForFilename(t *testing.T, c *client.CSAPI, mxcUri string, diffName
 		t.Fatalf("Got err when parsing content disposition: %s", err)
 	}
 
-	if mediaType != "inline" {
-		t.Fatalf("Found unexpected mediatype %s, expected inline", mediaType)
+	if mediaType != "attachment" {
+		t.Fatalf("Found unexpected mediatype %s, expected attachment", mediaType)
 	}
 
 	if filename, ok := params["filename"]; ok {

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ func TestMediaFilenames(t *testing.T) {`
`118`	`118`	`})`
`119`	`119`	`}`
`120`	`120`
`121`		`-// Returns content disposition information like (inline, filename)`
	`121`	`+// Returns content disposition information like (mediatype, filename)`
`122`	`122`	`func downloadForFilename(t testing.T, c client.CSAPI, mxcUri string, diffName string) string {`
`123`	`123`	`t.Helper()`
`124`	`124`
`@@ -139,8 +139,8 @@ func downloadForFilename(t testing.T, c client.CSAPI, mxcUri string, diffName`
`139`	`139`	`t.Fatalf("Got err when parsing content disposition: %s", err)`
`140`	`140`	`}`
`141`	`141`
`142`		`- if mediaType != "inline" {`
`143`		`- t.Fatalf("Found unexpected mediatype %s, expected inline", mediaType)`
	`142`	`+ if mediaType != "attachment" {`
	`143`	`+ t.Fatalf("Found unexpected mediatype %s, expected attachment", mediaType)`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`if filename, ok := params["filename"]; ok {`