Throw clearer error if createSecretStorageKey misbehaves (#4412)

element-hq/element-web#27888 shows a slightly
mysterious error message, but the problem is `createSecretStorageKey`
returning the wrong thing.

Author: richvdh

Diff for: src/rust-crypto/rust-crypto.ts

@@ -777,6 +777,9 @@ export class RustCrypto extends TypedEventEmitter<RustCryptoEvents, RustCryptoEv
             // Create a new storage key and add it to secret storage
             this.logger.info("bootstrapSecretStorage: creating new secret storage key");
             const recoveryKey = await createSecretStorageKey();
+            if (!recoveryKey) {
+                throw new Error("createSecretStorageKey() callback did not return a secret storage key");
+            }
             await this.addSecretStorageKeyToSecretStorage(recoveryKey);
         }