@@ -23,19 +23,25 @@ Things that should go into your PR description:
23
23
* A changelog entry in the ` Notes ` section (see below)
24
24
* References to any bugs fixed by the change (in GitHub's ` Fixes ` notation)
25
25
* Describe the why and what is changing in the PR description so it's easy for
26
- onlookers and reviewers to onboard and context switch.
26
+ onlookers and reviewers to onboard and context switch. This information is
27
+ also helpful when we come back to look at this in 6 months and ask "why did
28
+ we do it like that?" we have a chance of finding out.
29
+ * Why didn't it work before? Why does it work now? What use cases does it
30
+ unlock?
31
+ * If you find yourself adding information on how the code works or why you
32
+ chose to do it the way you did, make sure this information is instead
33
+ written as comments in the code itself.
34
+ * Sometimes a PR can change considerably as it is developed. In this case,
35
+ the description should be updated to reflect the most recent state of
36
+ the PR. (It can be helpful to retain the old content under a suitable
37
+ heading, for additional context.)
27
38
* Include both ** before** and ** after** screenshots to easily compare and discuss
28
39
what's changing.
29
40
* Include a step-by-step testing strategy so that a reviewer can check out the
30
41
code locally and easily get to the point of testing your change.
31
42
* Add comments to the diff for the reviewer that might help them to understand
32
43
why the change is necessary or how they might better understand and review it.
33
44
34
- Things that should * not* go into your PR description:
35
- * Any information on how the code works or why you chose to do it the way
36
- you did. If this isn't obvious from your code, you haven't written enough
37
- comments.
38
-
39
45
We rely on information in pull request to populate the information that goes
40
46
into the changelogs our users see, both for the JS SDK itself and also for some
41
47
projects based on it. This is picked up from both labels on the pull request and
@@ -254,6 +260,12 @@ on Git 2.17+ you can mass signoff using rebase:
254
260
git rebase --signoff origin/develop
255
261
```
256
262
263
+ Review expectations
264
+ ===================
265
+
266
+ See https://github.com/vector-im/element-meta/wiki/Review-process
267
+
268
+
257
269
Merge Strategy
258
270
==============
259
271
0 commit comments