Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 15076ce

Browse files
Fix issues with custom themes (#6937)
Fallback to non-custom colors in custom themes Signed-off-by: Šimon Brandner <[email protected]>
1 parent a539ead commit 15076ce

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

res/themes/legacy-light/css/_legacy-light.scss

+10-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ $font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Arial
1212

1313
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Courier', monospace, 'Noto Color Emoji';
1414

15-
// Colors from Figma Compound https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=557%3A0
16-
$system: #F4F6FA;
17-
1815
// unified palette
1916
// try to use these colors when possible
2017
$accent-color: #03b381;
@@ -32,12 +29,22 @@ $primary-bg-color: #ffffff;
3229
$muted-fg-color: #61708b; // Commonly used in headings and relevant alt text
3330

3431
// Legacy theme backports
32+
$accent: #0DBD8B;
33+
$alert: #FF5B55;
34+
$links: #0086e6;
3535
$primary-content: $primary-fg-color;
3636
$secondary-content: $secondary-fg-color;
3737
$tertiary-content: $tertiary-fg-color;
3838
$quaternary-content: #C1C6CD;
3939
$quinary-content: #e3e8f0;
40+
$system: #F4F6FA;
4041
$background: $primary-bg-color;
42+
$panels: rgba($system, 0.9);
43+
$panel-base: #8D97A5; // This color is not intended for use in the app
44+
$panel-selected: rgba($tertiary-content, 0.3);
45+
$panel-hover: rgba($tertiary-content, 0.1);
46+
$panel-actions: rgba($tertiary-content, 0.2);
47+
$space-nav: rgba($tertiary-content, 0.15);
4148

4249
// used for dialog box text
4350
$light-fg-color: #747474;

res/themes/light-custom/css/_custom.scss

+11-11
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@ $font-family: var(--font-family, $font-family);
1818
$monospace-font-family: var(--font-family-monospace, $monospace-font-family);
1919

2020
// Colors from Figma Compound https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=559%3A741
21-
$accent: var(--accent);
22-
$alert: var(--alert);
23-
$links: var(--links);
24-
$primary-content: var(--primary-content);
25-
$secondary-content: var(--secondary-content);
26-
$tertiary-content: var(--tertiary-content);
27-
$quaternary-content: var(--quaternary-content);
28-
$quinary-content: var(--quinary-content);
29-
$system: var(--system);
30-
$background: var(--background);
21+
$accent: var(--accent, $accent);
22+
$alert: var(--alert, $alert);
23+
$links: var(--links, $links);
24+
$primary-content: var(--primary-content, $primary-content);
25+
$secondary-content: var(--secondary-content, $secondary-content);
26+
$tertiary-content: var(--tertiary-content, $tertiary-content);
27+
$quaternary-content: var(--quaternary-content, $quaternary-content);
28+
$quinary-content: var(--quinary-content, $quinary-content);
29+
$system: var(--system, $system);
30+
$background: var(--background, $background);
3131
$panels: rgba($system, 0.9);
32-
$panel-base: var(--panel-base); // This color is not intended for use in the app
32+
$panel-base: var(--panel-base, $tertiary-content); // This color is not intended for use in the app
3333
$panel-selected: rgba($panel-base, 0.3);
3434
$panel-hover: rgba($panel-base, 0.1);
3535
$panel-actions: rgba($panel-base, 0.2);

0 commit comments

Comments
 (0)