Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 52eec28

Browse files
authored
Quick settings: Change the copy / labels on the options (#10427)
* Quick settings: Change the copy / labels on the options * Update i18n
1 parent a340387 commit 52eec28

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

cypress/e2e/sliding-sync/sliding-sync.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ describe("Sliding Sync", () => {
202202

203203
// disable notifs in this room (TODO: CS API call?)
204204
cy.contains(".mx_RoomTile", "Test Room").find(".mx_RoomTile_notificationsButton").click({ force: true });
205-
cy.contains("Off").click();
205+
cy.contains("Mute room").click();
206206

207207
// create a new room so we know when the message has been received as it'll re-shuffle the room list
208208
cy.createRoom({

src/components/views/context_menus/RoomNotificationContextMenu.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
5252

5353
const defaultOption: JSX.Element = (
5454
<IconizedContextMenuRadio
55-
label={_t("Use default")}
55+
label={_t("Match default setting")}
5656
active={notificationState === RoomNotifState.AllMessages}
5757
iconClassName="mx_RoomNotificationContextMenu_iconBell"
5858
onClick={wrapHandler(() => setNotificationState(RoomNotifState.AllMessages))}
@@ -70,7 +70,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
7070

7171
const mentionsOption: JSX.Element = (
7272
<IconizedContextMenuRadio
73-
label={_t("Mentions & Keywords")}
73+
label={_t("Mentions & keywords")}
7474
active={notificationState === RoomNotifState.MentionsOnly}
7575
iconClassName="mx_RoomNotificationContextMenu_iconBellMentions"
7676
onClick={wrapHandler(() => setNotificationState(RoomNotifState.MentionsOnly))}
@@ -79,7 +79,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
7979

8080
const muteOption: JSX.Element = (
8181
<IconizedContextMenuRadio
82-
label={_t("Off")}
82+
label={_t("Mute room")}
8383
active={notificationState === RoomNotifState.Mute}
8484
iconClassName="mx_RoomNotificationContextMenu_iconBellCrossed"
8585
onClick={wrapHandler(() => setNotificationState(RoomNotifState.Mute))}

src/i18n/strings/en_EN.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -3255,8 +3255,8 @@
32553255
"Low Priority": "Low Priority",
32563256
"Forget Room": "Forget Room",
32573257
"Mark as read": "Mark as read",
3258-
"Use default": "Use default",
3259-
"Mentions & Keywords": "Mentions & Keywords",
3258+
"Match default setting": "Match default setting",
3259+
"Mute room": "Mute room",
32603260
"See room timeline (devtools)": "See room timeline (devtools)",
32613261
"Space": "Space",
32623262
"Space home": "Space home",

0 commit comments

Comments
 (0)