Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 9d0230b

Browse files
authored
Show the room name in the room header during calls (#9942)
1 parent da30b30 commit 9d0230b

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

res/css/views/rooms/_RoomHeader.pcss

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ limitations under the License.
108108
display: flex;
109109
user-select: none;
110110

111-
&:not(.mx_RoomHeader_name--textonly):hover {
111+
&:hover {
112112
background-color: $quinary-content;
113113
}
114114

src/components/views/rooms/RoomHeader.tsx

+8-10
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,13 @@ export default class RoomHeader extends React.Component<IProps, IState> {
743743

744744
const buttons = this.props.showButtons ? this.renderButtons(isVideoRoom) : null;
745745

746+
let oobName = _t("Join Room");
747+
if (this.props.oobData && this.props.oobData.name) {
748+
oobName = this.props.oobData.name;
749+
}
750+
751+
const name = this.renderName(oobName);
752+
746753
if (this.props.viewingCall && !isVideoRoom) {
747754
return (
748755
<header className="mx_RoomHeader light-panel">
@@ -752,9 +759,7 @@ export default class RoomHeader extends React.Component<IProps, IState> {
752759
>
753760
<div className="mx_RoomHeader_avatar">{roomAvatar}</div>
754761
{icon}
755-
<div className="mx_RoomHeader_name mx_RoomHeader_name--textonly mx_RoomHeader_name--small">
756-
{_t("Video call")}
757-
</div>
762+
{name}
758763
{this.props.activeCall instanceof ElementCall && (
759764
<GroupCallDuration groupCall={this.props.activeCall.groupCall} />
760765
)}
@@ -779,13 +784,6 @@ export default class RoomHeader extends React.Component<IProps, IState> {
779784
);
780785
}
781786

782-
let oobName = _t("Join Room");
783-
if (this.props.oobData && this.props.oobData.name) {
784-
oobName = this.props.oobData.name;
785-
}
786-
787-
const name = this.renderName(oobName);
788-
789787
const topicElement = <RoomTopic room={this.props.room} className="mx_RoomHeader_topic" />;
790788

791789
const viewLabs = (): void =>

src/i18n/strings/en_EN.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1997,9 +1997,9 @@
19971997
"Close call": "Close call",
19981998
"View chat timeline": "View chat timeline",
19991999
"Room options": "Room options",
2000+
"Join Room": "Join Room",
20002001
"(~%(count)s results)|other": "(~%(count)s results)",
20012002
"(~%(count)s results)|one": "(~%(count)s result)",
2002-
"Join Room": "Join Room",
20032003
"Video rooms are a beta feature": "Video rooms are a beta feature",
20042004
"Video room": "Video room",
20052005
"Public space": "Public space",

0 commit comments

Comments
 (0)