Use IncompatibleController to disable showLocation via labs flag (#7566)

Author: andybalaam

src/components/views/rooms/MessageComposer.tsx

@@ -286,10 +286,7 @@ export default class MessageComposer extends React.Component<IProps, IState> {
             showStickers: false,
             showStickersButton: SettingsStore.getValue("MessageComposerInput.showStickersButton"),
             showPollsButton: SettingsStore.getValue("feature_polls"),
-            showLocationButton: (
-                SettingsStore.getValue("feature_location_share") &&
-                SettingsStore.getValue("MessageComposerInput.showLocationButton")
-            ),
+            showLocationButton: SettingsStore.getValue("MessageComposerInput.showLocationButton"),
         };
 
         this.instanceId = instanceCount++;
@@ -354,12 +351,9 @@ export default class MessageComposer extends React.Component<IProps, IState> {
 
                     case "MessageComposerInput.showLocationButton":
                     case "feature_location_share": {
-                        const showLocationButton = (
-                            SettingsStore.getValue("feature_location_share") &&
-                            SettingsStore.getValue(
-                                "MessageComposerInput.showLocationButton",
-                            )
-                        );
+                        const showLocationButton = SettingsStore.getValue(
+                            "MessageComposerInput.showLocationButton");
+
                         if (this.state.showLocationButton !== showLocationButton) {
                             this.setState({ showLocationButton });
                         }

src/settings/Settings.tsx

@@ -418,7 +418,7 @@ export const SETTINGS: {[setting: string]: ISetting} = {
         supportedLevels: LEVELS_ACCOUNT_SETTINGS,
         displayName: _td('Enable location sharing'),
         default: true,
-        controller: new UIFeatureController(UIFeature.Widgets, false),
+        controller: new IncompatibleController("feature_location_share", false, false),
     },
     // TODO: Wire up appropriately to UI (FTUE notifications)
     "Notifications.alwaysShowBadgeCounts": {