Remove obsolete style rules - mx_SpaceRoomView_inviteTeammates_betaDisclaimer (#11004)

* Remove obsolete style rules - mx_SpaceRoomView_inviteTeammates_betaDisclaimer

* Remove the deprecated disclaimer

* Remove ExternalLink

* Add a Percy snapshot - 'Invite your teammates' dialog

Author: luixxiul

cypress/e2e/spaces/spaces.spec.ts

@@ -140,6 +140,8 @@ describe("Spaces", () => {
         cy.findByPlaceholderText("Support").type("Projects");
         cy.findByRole("button", { name: "Continue" }).click();
 
+        cy.get(".mx_SpaceRoomView").percySnapshotElement("Space - 'Invite your teammates' dialog");
+
         cy.get(".mx_SpaceRoomView").within(() => {
             cy.get("h1").findByText("Invite your teammates");
             cy.findByRole("button", { name: "Skip for now" }).click();

res/css/structures/_SpaceRoomView.pcss

@@ -271,23 +271,6 @@ $SpaceRoomViewInnerWidth: 428px;
     }
 
     .mx_SpaceRoomView_inviteTeammates {
-        /* XXX remove this when spaces leaves Beta */
-        .mx_SpaceRoomView_inviteTeammates_betaDisclaimer {
-            padding: 16px;
-            position: relative;
-            border-radius: 8px;
-            background-color: $header-panel-bg-color;
-            max-width: $SpaceRoomViewInnerWidth;
-            margin: 20px 0 30px;
-            box-sizing: border-box;
-
-            .mx_BetaCard_betaPill {
-                position: absolute;
-                left: 16px;
-                top: 16px;
-            }
-        }
-
         .mx_SpaceRoomView_inviteTeammates_buttons {
             color: $secondary-content;
             margin-top: 28px;

src/components/structures/SpaceRoomView.tsx

@@ -77,7 +77,6 @@ import MainSplit from "./MainSplit";
 import RightPanel from "./RightPanel";
 import SpaceHierarchy, { showRoom } from "./SpaceHierarchy";
 import { RoomPermalinkCreator } from "../../utils/permalinks/Permalinks";
-import ExternalLink from "../views/elements/ExternalLink";
 
 interface IProps {
     space: Room;
@@ -586,22 +585,6 @@ const SpaceSetupPrivateInvite: React.FC<{
                 {_t("Make sure the right people have access. You can invite more later.")}
             </div>
 
-            <div className="mx_SpaceRoomView_inviteTeammates_betaDisclaimer">
-                {_t(
-                    "<b>This is an experimental feature.</b> For now, " +
-                        "new users receiving an invite will have to open the invite on <link/> to actually join.",
-                    {},
-                    {
-                        b: (sub) => <b>{sub}</b>,
-                        link: () => (
-                            <ExternalLink href="https://app.element.io/" rel="noreferrer noopener" target="_blank">
-                                app.element.io
-                            </ExternalLink>
-                        ),
-                    },
-                )}
-            </div>
-
             {error && <div className="mx_SpaceRoomView_errorText">{error}</div>}
             <form onSubmit={onClick} id="mx_SpaceSetupPrivateInvite">
                 {fields}

src/i18n/strings/en_EN.json

@@ -3479,7 +3479,6 @@
     "Inviting…": "Inviting…",
     "Invite your teammates": "Invite your teammates",
     "Make sure the right people have access. You can invite more later.": "Make sure the right people have access. You can invite more later.",
-    "<b>This is an experimental feature.</b> For now, new users receiving an invite will have to open the invite on <link/> to actually join.": "<b>This is an experimental feature.</b> For now, new users receiving an invite will have to open the invite on <link/> to actually join.",
     "Invite by username": "Invite by username",
     "What are some things you want to discuss in %(spaceName)s?": "What are some things you want to discuss in %(spaceName)s?",
     "Let's create a room for each of them.": "Let's create a room for each of them.",