Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit ef69946

Browse files
authored
Improve combining diacritics in Chrome (#8687)
This makes all but 9 of U+20D0 to U+20F0 combine correctly on Chrome. See also https://bugs.chromium.org/p/chromium/issues/detail?id=1328898
1 parent e20ae18 commit ef69946

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

res/themes/legacy-light/css/_legacy-light.scss

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
1-
// XXX: check this?
21
/* Nunito lacks combining diacritics, so these will fall through
3-
to the next font. Helevetica's diacritics however do not combine
2+
to the next font. Helevetica's diacritics sometimes do not combine
43
nicely (on OSX, at least) and result in a huge horizontal mess.
5-
Arial empirically gets it right, hence prioritising Arial here. */
4+
Arial empirically gets it right, hence prioritising Arial here.
5+
We also include STIXGeneral explicitly to support a wider range
6+
of combining diacritics (Chrome fails without it, as per
7+
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898) */
68
/* We fall through to Twemoji for emoji rather than falling through
79
to native Emoji fonts (if any) to ensure cross-browser consistency */
810
/* Noto Color Emoji contains digits, in fixed-width, therefore causing
911
digits in flowed text to stand out.
1012
TODO: Consider putting all emoji fonts to the end rather than the front. */
11-
$font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Arial', 'Helvetica', sans-serif, 'Noto Color Emoji';
13+
$font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'STIXGeneral', 'Arial', 'Helvetica', sans-serif, 'Noto Color Emoji';
1214

13-
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Courier', monospace, 'Noto Color Emoji';
15+
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'STIXGeneral', 'Courier', monospace, 'Noto Color Emoji';
1416

1517
// unified palette
1618
// try to use these colors when possible

res/themes/light/css/_light.scss

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
// XXX: check this?
2-
/* Nunito lacks combining diacritics, so these will fall through
3-
to the next font. Helevetica's diacritics however do not combine
1+
/* Nunito and Inter lacks combining diacritics, so these will fall through
2+
to the next font. Helevetica's diacritics sometimes do not combine
43
nicely (on OSX, at least) and result in a huge horizontal mess.
5-
Arial empirically gets it right, hence prioritising Arial here. */
4+
Arial empirically gets it right, hence prioritising Arial here.
5+
We also include STIXGeneral explicitly to support a wider range
6+
of combining diacritics (Chrome fails without it, as per
7+
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898) */
68
/* We fall through to Twemoji for emoji rather than falling through
79
to native Emoji fonts (if any) to ensure cross-browser consistency */
810
/* Noto Color Emoji contains digits, in fixed-width, therefore causing
@@ -12,6 +14,7 @@ $font-family: 'Inter',
1214
'Twemoji',
1315
'Apple Color Emoji',
1416
'Segoe UI Emoji',
17+
'STIXGeneral',
1518
'Arial',
1619
'Helvetica',
1720
sans-serif,
@@ -21,6 +24,7 @@ $monospace-font-family: 'Inconsolata',
2124
'Twemoji',
2225
'Apple Color Emoji',
2326
'Segoe UI Emoji',
27+
'STIXGeneral',
2428
'Courier',
2529
monospace,
2630
'Noto Color Emoji';

0 commit comments

Comments
 (0)