feat(bindings/crypto-nodejs): Use latest napi-rs version to avoid cloning Uint8Array.

The new `napi-rs` release includes a patch that avoids cloning and
copying data inside a `Uint8Array`
(napi-rs/napi-rs#1224), it now returns a
“Node.js reference” of it.

This new `napi-rs` release also includes one of our patch,
napi-rs/napi-rs#1200, which means we no longer
need to depend on our fork.

Author: Hywan

Cargo.toml

@@ -30,8 +30,8 @@ matrix-sdk-common = { version = "0.5.0", path = "../../crates/matrix-sdk-common"
 matrix-sdk-sled = { version = "0.1.0", path = "../../crates/matrix-sdk-sled", default-features = false, features = ["crypto-store"] }
 ruma = { git = "https://github.com/ruma/ruma", rev = "96155915f", features = ["client-api-c", "rand", "unstable-msc2676", "unstable-msc2677"] }
 vodozemac = {  git = "https://github.com/matrix-org/vodozemac/", rev = "d0e744287a14319c2a9148fef3747548c740fc36" }
-napi = { git = "https://github.com/Hywan/napi-rs", branch = "feat-either-n-up-to-26", default-features = false, features = ["napi6", "tokio_rt"] }
-napi-derive = { git = "https://github.com/Hywan/napi-rs", branch = "feat-either-n-up-to-26" }
+napi = { version = "2.6.1", default-features = false, features = ["napi6", "tokio_rt"] }
+napi-derive = "2.6.0"
 serde_json = "1.0.79"
 http = "0.2.6"
 zeroize = "1.3.0"

src/attachment.rs

@@ -64,7 +64,9 @@ impl Attachment {
 #[napi]
 pub struct EncryptedAttachment {
     media_encryption_info: matrix_sdk_crypto::MediaEncryptionInfo,
-    encrypted_data: Uint8Array,
+
+    /// The actual encrypted data.
+    pub encrypted_data: Uint8Array,
 }
 
 #[napi]
@@ -93,14 +95,4 @@ impl EncryptedAttachment {
     pub fn media_encryption_info(&self) -> String {
         serde_json::to_string(&self.media_encryption_info).unwrap()
     }
-
-    /// Return a **copy** of the encrypted data in a new `Uint8Array`.
-    ///
-    /// We are aware this is not ideal to copy the value, but the
-    /// current available Node.js API does seem be limited in that
-    /// regard.
-    #[napi(getter)]
-    pub fn encrypted_data(&self) -> Uint8Array {
-        Uint8Array::new(self.encrypted_data.deref().to_owned())
-    }
 }