Skip to content

KeysUploadRequest generates malformed bodies #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #26566
richvdh opened this issue Nov 16, 2023 · 2 comments
Closed
Tracked by #26566

KeysUploadRequest generates malformed bodies #57

richvdh opened this issue Nov 16, 2023 · 2 comments

Comments

@richvdh
Copy link
Member

richvdh commented Nov 16, 2023

The body of KeysUploadRequest structs looks like this:

{"device_keys":null,"fallback_keys":{},"one_time_keys":{"signed_curve25519:AAAAAAAAAGY":{"key":"WEvbLtVJzuDZQTlzCowFdzfqyfjh4d8NhhyciQ4GxSs","signatures":{"@richvdh:sw1v.org":{"ed25519:JAVDMNZYHJ":"6hrLwCj+99R5lciirbmbdh2d+LbGEQEnAtv+HkEGAW1ODCa+7WDxFyoEZf74u9eWGCjSAmhd/OT5EMQ5yhWoAA"}}}}}

null is not a valid value for device_keys according to the spec, which requires it to be a JSON object if it is present.

Related: #56

@richvdh
Copy link
Member Author

richvdh commented Nov 16, 2023

As with #56, this feels like a result of doing our own serialisation rather than taking advantage of the existing serialisation attributes on the underlying Ruma type. /cc @Hywan

@uhoreg
Copy link
Member

uhoreg commented Jan 23, 2024

This was fixed by #72 Can someone close this? I don't have permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants