Apply suggestions from code review

Co-authored-by: Ivan Enderlin <[email protected]>

Author: gnunicorn

Diff for: crates/matrix-sdk-base/src/rooms/members.rs

@@ -47,8 +47,8 @@ impl RoomMember {
     }
 
     /// Get the original member event
-    pub fn event(&self) -> Arc<MemberEvent> {
-        self.event.clone()
+    pub fn event(&self) -> &Arc<MemberEvent> {
+        &self.event
     }
 
     /// Get the display name of the member if there is one.

Diff for: crates/matrix-sdk-common/src/deserialized_responses.rs

@@ -313,21 +313,21 @@ impl MemberEvent {
             MemberEvent::Stripped(e) => Some(&e.content),
         }
     }
-    /// The Sender of this event
+    /// The sender of this event.
     pub fn sender(&self) -> &UserId {
         match self {
             MemberEvent::Sync(e) => e.sender(),
             MemberEvent::Stripped(e) => e.sender.borrow(),
         }
     }
-    /// The EventId of this event
+    /// The ID of this event.
     pub fn event_id(&self) -> Option<&EventId> {
         match self {
             MemberEvent::Sync(e) => Some(e.event_id()),
             MemberEvent::Stripped(_) => None,
         }
     }
-    /// The Server Timestamp of this event
+    /// The Server Timestamp of this event.
     pub fn origin_server_ts(&self) -> Option<MilliSecondsSinceUnixEpoch> {
         match self {
             MemberEvent::Sync(e) => Some(e.origin_server_ts()),

Diff for: crates/matrix-sdk/src/room/invited.rs

@@ -13,18 +13,18 @@ pub struct Invited {
     pub(crate) inner: Common,
 }
 
-/// Details of the (latest) invite
+/// Details of the (latest) invite.
 #[derive(Debug, Clone)]
 pub struct Invite {
-    /// Who has been invited
+    /// Who has been invited.
     pub invitee: RoomMember,
-    /// Who sent the invite
+    /// Who sent the invite.
     pub inviter: Option<RoomMember>,
 }
 
 #[derive(Error, Debug)]
 pub enum InvitationError {
-    /// The client isn't logged in
+    /// The client isn't logged in.
     #[error("The client isn't authenticated")]
     NotAuthenticated,
     #[error("No membership event found")]
@@ -58,7 +58,7 @@ impl Invited {
         self.inner.join().await
     }
 
-    /// The membership details of the (latest) invite for this room
+    /// The membership details of the (latest) invite for this room.
     pub async fn invite_details(&self) -> Result<Invite> {
         let user_id = self
             .inner