Skip to content

Reinstate decode_verify_key_base64 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

Reinstate decode_verify_key_base64 #6

merged 1 commit into from
Mar 25, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 25, 2020

This method was incorrectly removed in 1.1.0, in PR #1

@richvdh
Reinstate decode_verify_key_base64
902ef53 
This method was incorrectly removed in 1.1.0.
@richvdh richvdh requested a review from a team March 25, 2020 11:22
anoadragon453
anoadragon453 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the motivation is that this is currently breaking for people trying to install old versions of Synapse (for some reason)?

@richvdh
Copy link
Member Author

richvdh commented Mar 25, 2020

mostly, yes.

@richvdh richvdh merged commit c8d9a37 into master Mar 25, 2020
@clokep clokep deleted the rav/reinstate_lost_method branch September 23, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @anoadragon453