Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 18e4092

Browse files
authoredSep 1, 2022
Bump docker image to use stable poetry version (#13688)
1 parent 0e99f07 commit 18e4092

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed
 

‎.github/workflows/tests.yml

-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,6 @@ jobs:
283283
- run: sudo apt-get -qq install xmlsec1
284284
- uses: matrix-org/setup-python-poetry@v1
285285
with:
286-
python-version: ${{ matrix.python-version }}
287286
extras: "postgres"
288287
- run: .ci/scripts/test_export_data_command.sh
289288

‎changelog.d/13688.docker

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update docker image to use a stable version of poetry.

‎docker/Dockerfile

+1-10
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,8 @@ RUN \
4646

4747
# We install poetry in its own build stage to avoid its dependencies conflicting with
4848
# synapse's dependencies.
49-
# We use a specific commit from poetry's master branch instead of our usual 1.1.14,
50-
# to incorporate fixes to some bugs in `poetry export`. This commit corresponds to
51-
# https://github.com/python-poetry/poetry/pull/5156 and
52-
# https://github.com/python-poetry/poetry/issues/5141 ;
53-
# without it, we generate a requirements.txt with incorrect environment markers,
54-
# which causes necessary packages to be omitted when we `pip install`.
55-
#
56-
# NB: In poetry 1.2 `poetry export` will be moved into a plugin; we'll need to also
57-
# pip install poetry-plugin-export (https://github.com/python-poetry/poetry-plugin-export).
5849
RUN --mount=type=cache,target=/root/.cache/pip \
59-
pip install --user "poetry-core==1.1.0a7" "git+https://github.com/python-poetry/poetry.git@fb13b3a676f476177f7937ffa480ee5cff9a90a5"
50+
pip install --user "poetry==1.2.0"
6051

6152
WORKDIR /synapse
6253

0 commit comments

Comments
 (0)
This repository has been archived.