Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 2f8ec8d

Browse files
author
David Robertson
committed
Add missing dependency on importlib_metadata
Missed in #12088. We got away with it because we were indirectly requiring it via other packages. Without this change, we encounter pain in `poetry export`; and besides, we should be explicit about our direct dependencies.
1 parent 70195e4 commit 2f8ec8d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

Diff for: pyproject.toml

+3
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,9 @@ ijson = ">=3.1.4"
167167
matrix-common = "~=1.1.0"
168168
# We need packaging.requirements.Requirement, added in 16.1.
169169
packaging = ">=16.1"
170+
# At the time of writing, we only use functions from the version `importlib.metadata`
171+
# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
172+
importlib_metadata = { version = ">=1.4", python = "<3.8" }
170173

171174

172175
# Optional Dependencies

Diff for: synapse/python_dependencies.py

+3
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@
8989
"matrix-common~=1.1.0",
9090
# We need packaging.requirements.Requirement, added in 16.1.
9191
"packaging>=16.1",
92+
# At the time of writing, we only use functions from the version `importlib.metadata`
93+
# which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
94+
"importlib_metadata>=1.4; python_version < 3.8",
9295
]
9396

9497
CONDITIONAL_REQUIREMENTS = {

0 commit comments

Comments
 (0)