Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 6ff99e3

Browse files
author
David Robertson
authored
Downgrade some OIDC exceptions to warnings (#12723)
1 parent a1cb05b commit 6ff99e3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Diff for: changelog.d/12723.misc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Downgrade some OIDC errors to warnings in the logs, to reduce the noise of Sentry reports.

Diff for: synapse/handlers/oidc.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ async def handle_oidc_callback(self, request: SynapseRequest) -> None:
224224
self._sso_handler.render_error(request, "invalid_session", str(e))
225225
return
226226
except MacaroonInvalidSignatureException as e:
227-
logger.exception("Could not verify session for OIDC callback")
227+
logger.warning("Could not verify session for OIDC callback: %s", e)
228228
self._sso_handler.render_error(request, "mismatching_session", str(e))
229229
return
230230

@@ -827,7 +827,7 @@ async def handle_oidc_callback(
827827
logger.debug("Exchanging OAuth2 code for a token")
828828
token = await self._exchange_code(code)
829829
except OidcError as e:
830-
logger.exception("Could not exchange OAuth2 code")
830+
logger.warning("Could not exchange OAuth2 code: %s", e)
831831
self._sso_handler.render_error(request, e.error, e.error_description)
832832
return
833833

0 commit comments

Comments
 (0)