Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 7a7ca8f

Browse files
authored
Use mock from standard library (#11588)
Instead of the backported version.
1 parent 8ad3943 commit 7a7ca8f

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

Diff for: changelog.d/11588.removal

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Replace `mock` package by its standard library version.

Diff for: setup.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@ def exec_file(path_segments):
120120
# Tests assume that all optional dependencies are installed.
121121
#
122122
# parameterized_class decorator was introduced in parameterized 0.7.0
123-
#
124-
# We use `mock` library as that backports `AsyncMock` to Python 3.6
125-
CONDITIONAL_REQUIREMENTS["test"] = ["parameterized>=0.7.0", "mock>=4.0.0"]
123+
CONDITIONAL_REQUIREMENTS["test"] = ["parameterized>=0.7.0"]
126124

127125
CONDITIONAL_REQUIREMENTS["dev"] = (
128126
CONDITIONAL_REQUIREMENTS["lint"]

Diff for: tests/storage/test_background_update.py

+8-9
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,14 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
# Use backported mock for AsyncMock support on Python 3.6.
16-
from mock import Mock
15+
from unittest.mock import Mock
1716

1817
from twisted.internet.defer import Deferred, ensureDeferred
1918

2019
from synapse.storage.background_updates import BackgroundUpdater
2120

2221
from tests import unittest
23-
from tests.test_utils import make_awaitable
22+
from tests.test_utils import make_awaitable, simple_async_mock
2423

2524

2625
class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
@@ -116,14 +115,14 @@ def prepare(self, reactor, clock, homeserver):
116115
)
117116

118117
# Mock out the AsyncContextManager
119-
self._update_ctx_manager = Mock(spec=["__aenter__", "__aexit__"])
120-
self._update_ctx_manager.__aenter__ = Mock(
121-
return_value=make_awaitable(None),
122-
)
123-
self._update_ctx_manager.__aexit__ = Mock(return_value=make_awaitable(None))
118+
class MockCM:
119+
__aenter__ = simple_async_mock(return_value=None)
120+
__aexit__ = simple_async_mock(return_value=None)
121+
122+
self._update_ctx_manager = MockCM
124123

125124
# Mock out the `update_handler` callback
126-
self._on_update = Mock(return_value=self._update_ctx_manager)
125+
self._on_update = Mock(return_value=self._update_ctx_manager())
127126

128127
# Define a default batch size value that's not the same as the internal default
129128
# value (100).

0 commit comments

Comments
 (0)